From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id F2A77431FBC for ; Mon, 12 Mar 2012 13:03:20 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.29 X-Spam-Level: X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UMCuxtBlz4hi for ; Mon, 12 Mar 2012 13:03:18 -0700 (PDT) Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu [131.215.239.19]) by olra.theworths.org (Postfix) with ESMTP id A5F72431FAF for ; Mon, 12 Mar 2012 13:03:18 -0700 (PDT) Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1]) by fire-doxen-postvirus (Postfix) with ESMTP id 0EAD02E50D4F; Mon, 12 Mar 2012 13:03:18 -0700 (PDT) X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new Received: from finestructure.net (gwave-92.ligo.caltech.edu [131.215.114.92]) (Authenticated sender: jrollins) by fire-doxen-submit (Postfix) with ESMTP id 443232E50BEE; Mon, 12 Mar 2012 13:03:15 -0700 (PDT) Received: by finestructure.net (Postfix, from userid 1000) id 29765762; Mon, 12 Mar 2012 13:03:15 -0700 (PDT) From: Jameson Graef Rollins To: Mark Walters , notmuch@notmuchmail.org Subject: Re: [PATCH 0/2] A bug in the exclude code In-Reply-To: <1331551914-28323-1-git-send-email-markwalters1009@gmail.com> References: <1331551914-28323-1-git-send-email-markwalters1009@gmail.com> User-Agent: Notmuch/0.11.1+266~gadb05cc (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Mon, 12 Mar 2012 13:03:12 -0700 Message-ID: <87r4wx7fjz.fsf@servo.finestructure.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Mar 2012 20:03:21 -0000 --=-=-= On Mon, 12 Mar 2012 11:31:52 +0000, Mark Walters wrote: > There is a bug in the exclude code (found by jrollins in the > --with-excluded series) but also present in master. None of the > current tests were finding it so the first patch adds two tests. Hey, Mark. Thanks so much for looking in to this. It look like this patch fixes the issue for me too! Very excited to see this all coming together. > The bug (and test failure) do not appear in all configuations: on my > main test machine (an oldish debian testing 32bit userspace with a > 64bit kernel and xapian 1.2.7) all tests pass. On my laptop (a recent > debian testing 64bit userspace and xapian 1.2.8) one of the new tests > fails. It was failing for me too, but looking closer at the test I actually found a bug: you accidentally used the old style --no-exclude option, instead of the new --with-excludes. When you fix the call all the tests pass fine. > The second patch fixes the behaviour for me but I don't see why it > should make a difference: searches for A and not B should give the > same results as A and not (A and B). It could be a bug in xapian, it > could be that I am not allowed to reuse queries as I do (is query1 = > query1 and query2 allowed?) or it could be some memory use bug on my > part. I can't explain it either, but there's certainly a lot about xapian that I don't understand. Maybe one of the xapian gurus will have some ideas (Olly? Austin?). Anyway, thanks again for pushing on all of this, Mark. jamie. PS. Not a big deal, but it would have been nice for this patch set to have been sent in-reply-to the original series it fixes, just to keep everything together. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBCAAGBQJPXlaAAAoJEO00zqvie6q898EQAJLAYwv2+PhThqNL1vhEsw1f xlxagA1g1UID0dnBJ+ft7fAgM81ieVdn5y6SHaLcgAgaWCTbPlClVcJSFeSAYi6P F2bylBVxVi3vh6E2D63tQSwWTktNeBDv8tkjbsknbfVbWuSIHRc0+MM1caG1CMmS r2FVkRijCqcW3MurZf03YTQDiWveKKbuH80kwgiV/s+iQI9BpXeu+i4p17/5Yur+ Zjz6jXR5kEmnB8pbxe/PuHbN78Epq2Yl0c8Mzov7/L6ctMv59NbLaVtn1bpC+BNJ 9b4n43lcZ99fd7WUiVlu0VCR1zPSKaFN8aThS9NwVdId98MfwFugwmiZTGlG3T5J YtkcWOkAWyi16+FLHphafAmUhBJCzzyk+UXzqy0l6mi9X1ehPNxocNejM4XjJPTR mY7EsXk4ZP31gMXPjuW9DLPlNLYILAsR8MUylrD3jJ5pqBeGsMgLFrKzpV7Hz9QU 2k5gqgGx/Zzfsock0Ft76CUdwk5jIQ9Fi8EysHOr4hmpmA/DFBdAe7k3dR21zXzK c8KIQ+r4IfEoO7zVAQHxY/hbDC282d3ZdwQOTKQbJhYFoRrBcUFv3s1ew/8FK9TA 4SXcNz3YkU58ott6EQv29fHjWzFVyW92LVks4b9sqs4XNdePgseYSqbTP9hJpsgv Op/xZ5hxU4gs7m0H24wr =lL1+ -----END PGP SIGNATURE----- --=-=-=--