From: David Bremner <david@tethera.net>
To: "Antoine Beaupré" <anarcat@orangeseeds.org>, notmuch@notmuchmail.org
Cc: Tomi Ollila <tomi.ollila@iki.fi>
Subject: Re: [PATCH] WIP: test patch for reference loop problem
Date: Fri, 13 Apr 2018 08:17:42 -0300 [thread overview]
Message-ID: <87po33qrs9.fsf@tethera.net> (raw)
In-Reply-To: <87r2nkynj2.fsf@curie.anarc.at>
Antoine Beaupré <anarcat@orangeseeds.org> writes:
> Hi!
>
> So I've tried the patch and it seems to fix the bug. I'll run with a
> patch version for a while to see if anything's off, but so far so good
> I'd say.
>
> Furthermore, it's not possible for me to reproduce the bug in my regular
> mailbox anymore. I suspect this is because new mail came in and the file
> order in the directories changed, so the bug isn't triggered anymore.
>
> I was able to trigger the bug with the reproducer with an older build of
> the code though, so don't worry about that part. :)
Thanks for testing!
> Let me know if you need anything else from me before this gets merged.
>
There was also a test patch, basically adding your reproducer to the
test suite. It would be good to know if that test still reproduces the
problem, before the fix is applied. Tomi mentioned a more reduced test
set. That could reduce the privacy loss a bit, but as far as file size
these messages are pretty small, so I'm not sure if it's worth the
trouble/risk of breaking the reproducer.
I want to refactor the code a bit and hopefully cut down on the
copy-pasta, so I will probably ask you check a second version.
s
next prev parent reply other threads:[~2018-04-13 11:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-19 13:25 bug: "no top level messages" crash on Zen email loops Antoine Beaupré
2018-03-19 16:36 ` David Bremner
2018-03-19 17:50 ` Antoine Beaupré
2018-03-19 17:56 ` Antoine Beaupré
2018-03-19 19:25 ` tip: how to not forget attachments Antoine Beaupré
2018-03-19 19:57 ` Brian Sniffen
2018-03-19 20:16 ` Antoine Beaupré
2018-03-19 21:40 ` Brian Sniffen
2018-03-19 21:47 ` Antoine Beaupré
2018-03-19 20:03 ` bug: "no top level messages" crash on Zen email loops David Bremner
2018-03-29 3:17 ` Olly Betts
2018-03-29 12:50 ` Antoine Beaupré
2018-03-29 16:31 ` David Bremner
2018-03-30 4:35 ` Olly Betts
2018-03-20 21:22 ` [PATCH 1/2] test: two new messages for the 'broken' corpus David Bremner
2018-03-20 21:22 ` [PATCH 2/2] test: add known broken test for indexing an In-Reply-To loop David Bremner
2018-03-20 22:09 ` Tomi Ollila
2018-03-21 1:34 ` David Bremner
2018-04-02 11:03 ` [PATCH] WIP: test patch for reference loop problem David Bremner
2018-04-13 0:10 ` Antoine Beaupré
2018-04-13 11:17 ` David Bremner [this message]
2018-04-28 13:28 ` bug: "no top level messages" crash on Zen email loops David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87po33qrs9.fsf@tethera.net \
--to=david@tethera.net \
--cc=anarcat@orangeseeds.org \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).