unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Brian Sniffen <bts@evenmere.org>
To: "Antoine Beaupré" <anarcat@orangeseeds.org>
Cc: notmuch@notmuchmail.org
Subject: Re: tip: how to not forget attachments
Date: Mon, 19 Mar 2018 15:57:05 -0400	[thread overview]
Message-ID: <64758D7F-2CB7-4D48-ABB9-143C75785CB0@evenmere.org> (raw)
In-Reply-To: <87fu4v27hb.fsf@curie.anarc.at>

[-- Attachment #1: Type: text/plain, Size: 1768 bytes --]

`error` doesn’t do any unwinding; it leaves the program state wherever it was for analysis.  You probably want throw/catch, as described at https://www.gnu.org/software/emacs/manual/html_node/elisp/Catch-and-Throw.html#Catch-and-Throw

-- 
Brian Sniffen

> On Mar 19, 2018, at 3:25 PM, Antoine Beaupré <anarcat@orangeseeds.org> wrote:
> 
>> On 2018-03-19 13:56:54, Antoine Beaupré wrote:
>> PS: don't we have a "you forgot to actually attach the damn file" plugin
>> when we detect the word "attachment" and there's no attach? :p
> 
> So I figured that one out, I think. Before adding it to the wiki, I'd
> like a review of the code (attached) from more adept elisp programmers.
> 
> I'm particularly surprised that save-excursion doesn't work the way I
> expect: when I answer "no" to the question, I go back to the email
> buffer, but the point is invariably at the end of the buffer, whereas I
> would expect it to be where it was when I send the message. It looks
> like something else moves the mark before my hook, but I'm not sure
> what...
> 
> How else than (error) or (keyboard-quit) am I supposed to abort email
> sending? (message-send) uses the latter but it would seem better to use
> an actual error message than to just "beep" our way out here..
> 
> Other advice? (save-excursion) + (goto-char (point-min)) +
> (re-search-forward), is that idiomatic? or is there something more
> clever that should be done?
> 
> thanks!
> 
> -- 
> Tu connaîtras la vérité de ton chemin à ce qui te rend heureux.
>                        - Aristote
> <notmuch-buddha.el>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch

[-- Attachment #2: Type: text/html, Size: 2970 bytes --]

  reply	other threads:[~2018-03-19 19:57 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-19 13:25 bug: "no top level messages" crash on Zen email loops Antoine Beaupré
2018-03-19 16:36 ` David Bremner
2018-03-19 17:50   ` Antoine Beaupré
2018-03-19 17:56     ` Antoine Beaupré
2018-03-19 19:25       ` tip: how to not forget attachments Antoine Beaupré
2018-03-19 19:57         ` Brian Sniffen [this message]
2018-03-19 20:16           ` Antoine Beaupré
2018-03-19 21:40             ` Brian Sniffen
2018-03-19 21:47               ` Antoine Beaupré
2018-03-19 20:03     ` bug: "no top level messages" crash on Zen email loops David Bremner
2018-03-29  3:17       ` Olly Betts
2018-03-29 12:50         ` Antoine Beaupré
2018-03-29 16:31           ` David Bremner
2018-03-30  4:35           ` Olly Betts
2018-03-20 21:22 ` [PATCH 1/2] test: two new messages for the 'broken' corpus David Bremner
2018-03-20 21:22   ` [PATCH 2/2] test: add known broken test for indexing an In-Reply-To loop David Bremner
2018-03-20 22:09     ` Tomi Ollila
2018-03-21  1:34       ` David Bremner
2018-04-02 11:03     ` [PATCH] WIP: test patch for reference loop problem David Bremner
2018-04-13  0:10       ` Antoine Beaupré
2018-04-13 11:17         ` David Bremner
2018-04-28 13:28 ` bug: "no top level messages" crash on Zen email loops David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=64758D7F-2CB7-4D48-ABB9-143C75785CB0@evenmere.org \
    --to=bts@evenmere.org \
    --cc=anarcat@orangeseeds.org \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).