From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id B5B926DE021C for ; Fri, 13 Apr 2018 04:17:49 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[AWL=0.011, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Bcy_XERGu3FB for ; Fri, 13 Apr 2018 04:17:48 -0700 (PDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by arlo.cworth.org (Postfix) with ESMTPS id AE0106DE021A for ; Fri, 13 Apr 2018 04:17:48 -0700 (PDT) Received: from remotemail by fethera.tethera.net with local (Exim 4.89) (envelope-from ) id 1f6wi7-0006IH-RQ; Fri, 13 Apr 2018 07:17:43 -0400 Received: (nullmailer pid 3984 invoked by uid 1000); Fri, 13 Apr 2018 11:17:42 -0000 From: David Bremner To: Antoine =?utf-8?Q?Beaupr=C3=A9?= , notmuch@notmuchmail.org Cc: Tomi Ollila Subject: Re: [PATCH] WIP: test patch for reference loop problem In-Reply-To: <87r2nkynj2.fsf@curie.anarc.at> References: <20180320212235.29113-2-david@tethera.net> <20180402110355.16419-1-david@tethera.net> <87r2nkynj2.fsf@curie.anarc.at> X-List-To: notmuch Date: Fri, 13 Apr 2018 08:17:42 -0300 Message-ID: <87po33qrs9.fsf@tethera.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Apr 2018 11:17:49 -0000 Antoine Beaupr=C3=A9 writes: > Hi! > > So I've tried the patch and it seems to fix the bug. I'll run with a > patch version for a while to see if anything's off, but so far so good > I'd say. > > Furthermore, it's not possible for me to reproduce the bug in my regular > mailbox anymore. I suspect this is because new mail came in and the file > order in the directories changed, so the bug isn't triggered anymore. > > I was able to trigger the bug with the reproducer with an older build of > the code though, so don't worry about that part. :) Thanks for testing! > Let me know if you need anything else from me before this gets merged. > There was also a test patch, basically adding your reproducer to the test suite. It would be good to know if that test still reproduces the problem, before the fix is applied. Tomi mentioned a more reduced test set. That could reduce the privacy loss a bit, but as far as file size these messages are pretty small, so I'm not sure if it's worth the trouble/risk of breaking the reproducer. I want to refactor the code a bit and hopefully cut down on the copy-pasta, so I will probably ask you check a second version. s