From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
To: David Bremner <david@tethera.net>,
Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH v4 3/3] cli/reply: make --decrypt take a keyword
Date: Thu, 28 Dec 2017 22:28:23 -0500 [thread overview]
Message-ID: <87k1x6i560.fsf@fifthhorseman.net> (raw)
In-Reply-To: <874loha4br.fsf@tethera.net>
On Sat 2017-12-23 10:47:52 -0400, David Bremner wrote:
> Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:
>> + { .opt_keyword = (int*)(¶ms.crypto.decrypt), .name = "decrypt",
>> + .keyword_no_arg_value = "true", .keywords =
>> + (notmuch_keyword_t []){ { "false", NOTMUCH_DECRYPT_FALSE },
>> + { "auto", NOTMUCH_DECRYPT_AUTO },
>> + { "true", NOTMUCH_DECRYPT_NOSTASH },
>> + { 0, 0 } } },
>
> same question as for show, should we support --decrypt=nostash ?
No, we should not support --decrypt=nostash for show or reply. The
semantics of the display commands (show, reply) are such that they
*never* modify the index or stash anything in there. The equivalent for
the indexing (new, insert, reindex) commands' "--decrypt=nostash" in the
display commands is simply "--decrypt=true".
If you take a look at the subsequent series that follows this one,
you'll see that i offer a "--decrypt=stash" command "notmuch show", but
it makes some unusual assumptions (in particular, about opening the
database read/write, which "notmuch show" has never needed to do
before).
So, in case it wasn't clear: i've thought pretty hard about these
commands and the options that users are likely to want or need.
But the current series (under discussion in this thread) should be
applied *without* those additional changes -- i don't want to have the
whole controversy about "notmuch show --decrypt=stash" now. :)
--dkg
next prev parent reply other threads:[~2017-12-29 3:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 16:40 [PATCHES v4] Encourage explicit arguments for --decrypt in "show" and "reply" Daniel Kahn Gillmor
2017-12-19 16:40 ` [PATCH v4 1/3] cli: some keyword options can be supplied with no argument Daniel Kahn Gillmor
2017-12-23 14:29 ` David Bremner
2017-12-25 18:42 ` [PATCH] " David Bremner
2017-12-31 12:58 ` David Bremner
2017-12-29 3:45 ` [PATCH v4 1/3] " Daniel Kahn Gillmor
2017-12-19 16:40 ` [PATCH v4 2/3] cli/show: make --decrypt take a keyword Daniel Kahn Gillmor
2017-12-23 14:39 ` David Bremner
2017-12-29 3:51 ` Daniel Kahn Gillmor
2017-12-19 16:40 ` [PATCH v4 3/3] cli/reply: " Daniel Kahn Gillmor
2017-12-23 14:47 ` David Bremner
2017-12-29 3:28 ` Daniel Kahn Gillmor [this message]
2017-12-29 14:30 ` David Bremner
2017-12-29 23:04 ` Daniel Kahn Gillmor
2017-12-30 13:05 ` David Bremner
2017-12-31 0:38 ` Daniel Kahn Gillmor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k1x6i560.fsf@fifthhorseman.net \
--to=dkg@fifthhorseman.net \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).