From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id A5B786DE014D for ; Thu, 28 Dec 2017 19:51:40 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.009 X-Spam-Level: X-Spam-Status: No, score=-0.009 tagged_above=-999 required=5 tests=[AWL=-0.009] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MuZgxK0T7sCX for ; Thu, 28 Dec 2017 19:51:36 -0800 (PST) Received: from che.mayfirst.org (che.mayfirst.org [162.247.75.118]) by arlo.cworth.org (Postfix) with ESMTPS id 8979D6DE019C for ; Thu, 28 Dec 2017 19:51:36 -0800 (PST) Received: from fifthhorseman.net (ool-6c3a0662.static.optonline.net [108.58.6.98]) by che.mayfirst.org (Postfix) with ESMTPSA id 9E6C3F99B; Thu, 28 Dec 2017 22:51:35 -0500 (EST) Received: by fifthhorseman.net (Postfix, from userid 1000) id 9DB3320A90; Thu, 28 Dec 2017 22:28:23 -0500 (EST) From: Daniel Kahn Gillmor To: David Bremner , Notmuch Mail Subject: Re: [PATCH v4 3/3] cli/reply: make --decrypt take a keyword In-Reply-To: <874loha4br.fsf@tethera.net> References: <20171219164055.20778-1-dkg@fifthhorseman.net> <20171219164055.20778-4-dkg@fifthhorseman.net> <874loha4br.fsf@tethera.net> Date: Thu, 28 Dec 2017 22:28:23 -0500 Message-ID: <87k1x6i560.fsf@fifthhorseman.net> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Dec 2017 03:51:40 -0000 On Sat 2017-12-23 10:47:52 -0400, David Bremner wrote: > Daniel Kahn Gillmor writes: >> + { .opt_keyword = (int*)(¶ms.crypto.decrypt), .name = "decrypt", >> + .keyword_no_arg_value = "true", .keywords = >> + (notmuch_keyword_t []){ { "false", NOTMUCH_DECRYPT_FALSE }, >> + { "auto", NOTMUCH_DECRYPT_AUTO }, >> + { "true", NOTMUCH_DECRYPT_NOSTASH }, >> + { 0, 0 } } }, > > same question as for show, should we support --decrypt=nostash ? No, we should not support --decrypt=nostash for show or reply. The semantics of the display commands (show, reply) are such that they *never* modify the index or stash anything in there. The equivalent for the indexing (new, insert, reindex) commands' "--decrypt=nostash" in the display commands is simply "--decrypt=true". If you take a look at the subsequent series that follows this one, you'll see that i offer a "--decrypt=stash" command "notmuch show", but it makes some unusual assumptions (in particular, about opening the database read/write, which "notmuch show" has never needed to do before). So, in case it wasn't clear: i've thought pretty hard about these commands and the options that users are likely to want or need. But the current series (under discussion in this thread) should be applied *without* those additional changes -- i don't want to have the whole controversy about "notmuch show --decrypt=stash" now. :) --dkg