unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
To: Notmuch Mail <notmuch@notmuchmail.org>
Subject: [PATCHES v4] Encourage explicit arguments for --decrypt in "show" and "reply" 
Date: Tue, 19 Dec 2017 11:40:52 -0500	[thread overview]
Message-ID: <20171219164055.20778-1-dkg@fifthhorseman.net> (raw)

This is a clean revision of the series that was first introduced at
id:20171212001858.706-1-dkg@fifthhorseman.net.  It needed to be
rebased after Jani's boolean/negation series.  It should now apply
cleanly.

I think it's important to apply this series before releasing 0.26,
because of the interaction between Jani's boolean/negation series and
the introduction of a keyword-based --decrypt for the indexing
subcommands.  For consistency, it would be unpleasant if some commands
offer --no-decrypt, while others require --decrypt=false.

Background
----------

The notmuch indexing subcommands ("new", "insert", and "reindex") now
have a --decrypt option that takes an argument (the decryption
policy), since the session-keys patches have landed.

But the viewing subcommands ("show" and "reply") have their
traditional --decrypt option that (as a boolean) need not take an
argument, having --decrypt not present means something different from
either --decrypt=true or --decrypt=false.

This series allows the user to explicitly choose --decrypt=auto for
the viewing subcommands, while allowing people to use the
argument-free form (as an alias for --decrypt=true), but warns the
user to encourage them to switch to using an explicit argument
instead.

This is useful normalizing work for the interface, so it's worthwhile
on its own. It is also necessary preparation in the event that we
decide we want to:

 * set up a notmuch configuration option that changes the default for
   --decrypt for the viewing subcommands

 * allow "notmuch show" to actually index encrypted messages upon
   their first encounter (e.g., via a new decryption policy, which
   i'll propose separately)

Regards,

        --dkg

             reply	other threads:[~2017-12-19 16:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-19 16:40 Daniel Kahn Gillmor [this message]
2017-12-19 16:40 ` [PATCH v4 1/3] cli: some keyword options can be supplied with no argument Daniel Kahn Gillmor
2017-12-23 14:29   ` David Bremner
2017-12-25 18:42     ` [PATCH] " David Bremner
2017-12-31 12:58       ` David Bremner
2017-12-29  3:45     ` [PATCH v4 1/3] " Daniel Kahn Gillmor
2017-12-19 16:40 ` [PATCH v4 2/3] cli/show: make --decrypt take a keyword Daniel Kahn Gillmor
2017-12-23 14:39   ` David Bremner
2017-12-29  3:51     ` Daniel Kahn Gillmor
2017-12-19 16:40 ` [PATCH v4 3/3] cli/reply: " Daniel Kahn Gillmor
2017-12-23 14:47   ` David Bremner
2017-12-29  3:28     ` Daniel Kahn Gillmor
2017-12-29 14:30       ` David Bremner
2017-12-29 23:04         ` Daniel Kahn Gillmor
2017-12-30 13:05           ` David Bremner
2017-12-31  0:38             ` Daniel Kahn Gillmor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171219164055.20778-1-dkg@fifthhorseman.net \
    --to=dkg@fifthhorseman.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).