[PATCH] emacs: Add missing type and group to defcustom variable

[PATCH] emacs: Add missing type and group to defcustom variable

[Örjan Ekeberg]

Added the type 'regexp and group 'notmuch-send as properties to the
customizable variable notmuch-mua-attachment-regexp.
---
 emacs/notmuch-mua.el | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
index 94fa19d7..7fdd76bc 100644
--- a/emacs/notmuch-mua.el
+++ b/emacs/notmuch-mua.el
@@ -121,7 +121,9 @@ multiple parts get a header."
   "Message body text indicating that an attachment is expected.
 
 This is not used unless `notmuch-mua-attachment-check' is added
-to `notmuch-mua-send-hook'.")
+to `notmuch-mua-send-hook'."
+  :type 'regexp
+  :group 'notmuch-send)
 
 ;;
 
-- 
2.20.1

Re: [PATCH] emacs: Add missing type and group to defcustom variable

[David Edmondson]

Obviously good.

On Monday, 2019-04-15 at 15:35:19 +02, Örjan Ekeberg wrote:

> Added the type 'regexp and group 'notmuch-send as properties to the
> customizable variable notmuch-mua-attachment-regexp.
> ---
>  emacs/notmuch-mua.el | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
> index 94fa19d7..7fdd76bc 100644
> --- a/emacs/notmuch-mua.el
> +++ b/emacs/notmuch-mua.el
> @@ -121,7 +121,9 @@ multiple parts get a header."
>    "Message body text indicating that an attachment is expected.
>  
>  This is not used unless `notmuch-mua-attachment-check' is added
> -to `notmuch-mua-send-hook'.")
> +to `notmuch-mua-send-hook'."
> +  :type 'regexp
> +  :group 'notmuch-send)
>  
>  ;;
>  
> -- 
> 2.20.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch

dme.
-- 
Please forgive me if I act a little strange, for I know not what I do.

Re: [PATCH] emacs: Add missing type and group to defcustom variable

[Daniel Kahn Gillmor]

On Mon 2019-04-15 15:35:19 +0200, Örjan Ekeberg wrote:
> Added the type 'regexp and group 'notmuch-send as properties to the
> customizable variable notmuch-mua-attachment-regexp.

This is clearly a good patch, and better than
id:20190420195359.23399-1-dkg@fifthhorseman.net which i'd sent to try to
address the same issue (Örjan adds both group and type, and i only added
type).

Tomi also reviewed my patch and said it was ok, i'm assuming that the
result would be the same on this one.  I think it should be merged.

Thanks, Örjan!

       --dkg

Re: [PATCH] emacs: Add missing type and group to defcustom variable

[David Bremner]

Örjan Ekeberg <ekeberg@kth.se> writes:

> Added the type 'regexp and group 'notmuch-send as properties to the
> customizable variable notmuch-mua-attachment-regexp.

pushed,

d