unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
To: "Örjan Ekeberg" <ekeberg@kth.se>, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: Add missing type and group to defcustom variable
Date: Wed, 24 Apr 2019 01:52:12 -0400	[thread overview]
Message-ID: <877ebkt0fn.fsf@fifthhorseman.net> (raw)
In-Reply-To: <20190415133519.4532-1-ekeberg@kth.se>

On Mon 2019-04-15 15:35:19 +0200, Örjan Ekeberg wrote:
> Added the type 'regexp and group 'notmuch-send as properties to the
> customizable variable notmuch-mua-attachment-regexp.

This is clearly a good patch, and better than
id:20190420195359.23399-1-dkg@fifthhorseman.net which i'd sent to try to
address the same issue (Örjan adds both group and type, and i only added
type).

Tomi also reviewed my patch and said it was ok, i'm assuming that the
result would be the same on this one.  I think it should be merged.

Thanks, Örjan!

       --dkg

  parent reply	other threads:[~2019-04-24  5:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-15 13:35 [PATCH] emacs: Add missing type and group to defcustom variable Örjan Ekeberg
2019-04-15 13:53 ` David Edmondson
2019-04-24  5:52 ` Daniel Kahn Gillmor [this message]
2019-04-24 10:10 ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877ebkt0fn.fsf@fifthhorseman.net \
    --to=dkg@fifthhorseman.net \
    --cc=ekeberg@kth.se \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).