From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
To: Piotr Trojanek <piotr.trojanek@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH 4/5] fix wrong printf formatting of signed/unsigned integers
Date: Wed, 21 Jun 2017 12:11:27 -0400 [thread overview]
Message-ID: <87fuetiamo.fsf@fifthhorseman.net> (raw)
In-Reply-To: <20170616225026.8098-4-piotr.trojanek@gmail.com>
this series up to patch 4 LGTM, and seem uncontroversial. patch 5 adds
FIXMEs that should probably actually be fixed, though, rather than just
flagged.
Thanks to Piotr for identifying these issues and suggesting the
cleanup.
--dkg
next prev parent reply other threads:[~2017-06-21 16:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-16 22:50 [PATCH 1/5] minor whitespace cleanups Piotr Trojanek
2017-06-16 22:50 ` [PATCH 2/5] add leaks due to missing invocations of va_end Piotr Trojanek
2017-06-16 22:50 ` [PATCH 3/5] remove ineffective assignments Piotr Trojanek
2017-08-20 13:56 ` Jani Nikula
2017-06-16 22:50 ` [PATCH 4/5] fix wrong printf formatting of signed/unsigned integers Piotr Trojanek
2017-06-21 16:11 ` Daniel Kahn Gillmor [this message]
2017-06-26 12:14 ` Piotr Trojanek
2017-06-26 13:04 ` David Bremner
2017-06-26 22:54 ` David Bremner
2017-06-25 12:57 ` David Bremner
2017-06-16 22:50 ` [PATCH 5/5] flag potential problems with FIXME Piotr Trojanek
2017-06-25 12:34 ` [PATCH 1/5] minor whitespace cleanups David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fuetiamo.fsf@fifthhorseman.net \
--to=dkg@fifthhorseman.net \
--cc=notmuch@notmuchmail.org \
--cc=piotr.trojanek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).