From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 654236DE26F8 for ; Wed, 21 Jun 2017 09:56:51 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.052 X-Spam-Level: X-Spam-Status: No, score=-0.052 tagged_above=-999 required=5 tests=[AWL=-0.052] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id m2NK4IIOXi4U for ; Wed, 21 Jun 2017 09:56:50 -0700 (PDT) Received: from che.mayfirst.org (che.mayfirst.org [162.247.75.118]) by arlo.cworth.org (Postfix) with ESMTP id A86A16DE26F7 for ; Wed, 21 Jun 2017 09:56:50 -0700 (PDT) Received: from fifthhorseman.net (unknown [38.109.115.130]) by che.mayfirst.org (Postfix) with ESMTPSA id EB444F9A6; Wed, 21 Jun 2017 12:56:47 -0400 (EDT) Received: by fifthhorseman.net (Postfix, from userid 1000) id F40892072D; Wed, 21 Jun 2017 12:11:27 -0400 (EDT) From: Daniel Kahn Gillmor To: Piotr Trojanek , notmuch@notmuchmail.org Subject: Re: [PATCH 4/5] fix wrong printf formatting of signed/unsigned integers In-Reply-To: <20170616225026.8098-4-piotr.trojanek@gmail.com> References: <20170616225026.8098-1-piotr.trojanek@gmail.com> <20170616225026.8098-4-piotr.trojanek@gmail.com> Date: Wed, 21 Jun 2017 12:11:27 -0400 Message-ID: <87fuetiamo.fsf@fifthhorseman.net> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jun 2017 16:56:51 -0000 this series up to patch 4 LGTM, and seem uncontroversial. patch 5 adds FIXMEs that should probably actually be fixed, though, rather than just flagged. Thanks to Piotr for identifying these issues and suggesting the cleanup. --dkg