From: Piotr Trojanek <piotr.trojanek@gmail.com>
To: notmuch@notmuchmail.org
Subject: [PATCH 2/5] add leaks due to missing invocations of va_end
Date: Fri, 16 Jun 2017 23:50:23 +0100 [thread overview]
Message-ID: <20170616225026.8098-2-piotr.trojanek@gmail.com> (raw)
In-Reply-To: <20170616225026.8098-1-piotr.trojanek@gmail.com>
As the Linux man page states: "Each invocation of va_start() must be
matched by a corresponding invocation of va_end() in the same
function." Detected by cppcheck.
---
tag-util.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git tag-util.c tag-util.c
index 7091d294..30c2c077 100644
--- tag-util.c
+++ tag-util.c
@@ -28,6 +28,9 @@ line_error (tag_parse_status_t status,
fprintf (stderr, status < 0 ? "Error: " : "Warning: ");
vfprintf (stderr, format, va_args);
fprintf (stderr, " [%s]\n", line);
+
+ va_end (va_args);
+
return status;
}
@@ -200,6 +203,8 @@ message_error (notmuch_message_t *message,
vfprintf (stderr, format, va_args);
fprintf (stderr, "Message-ID: %s\n", notmuch_message_get_message_id (message));
fprintf (stderr, "Status: %s\n", notmuch_status_to_string (status));
+
+ va_end (va_args);
}
static int
--
2.11.0
next prev parent reply other threads:[~2017-06-16 22:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-16 22:50 [PATCH 1/5] minor whitespace cleanups Piotr Trojanek
2017-06-16 22:50 ` Piotr Trojanek [this message]
2017-06-16 22:50 ` [PATCH 3/5] remove ineffective assignments Piotr Trojanek
2017-08-20 13:56 ` Jani Nikula
2017-06-16 22:50 ` [PATCH 4/5] fix wrong printf formatting of signed/unsigned integers Piotr Trojanek
2017-06-21 16:11 ` Daniel Kahn Gillmor
2017-06-26 12:14 ` Piotr Trojanek
2017-06-26 13:04 ` David Bremner
2017-06-26 22:54 ` David Bremner
2017-06-25 12:57 ` David Bremner
2017-06-16 22:50 ` [PATCH 5/5] flag potential problems with FIXME Piotr Trojanek
2017-06-25 12:34 ` [PATCH 1/5] minor whitespace cleanups David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170616225026.8098-2-piotr.trojanek@gmail.com \
--to=piotr.trojanek@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).