From: "Jose A. Ortega Ruiz" <jao@gnu.org>
To: David Bremner <david@tethera.net>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH v7 1/1] emacs: notmuch-tree-outline-mode
Date: Tue, 13 Dec 2022 02:19:25 +0000 [thread overview]
Message-ID: <87fsdk82qa.fsf@mail.jao.io> (raw)
In-Reply-To: <87r0x48h71.fsf@mail.jao.io> (Jose A. Ortega Ruiz's message of "Mon, 12 Dec 2022 21:06:58 +0000")
On Mon, Dec 12 2022, Jose A. Ortega Ruiz wrote:
> took a second look, and yes, it's close but not quite. there are cases
> (when the message is not the first but its depth is 0) where its outline
> level doesn't match the depth. we could store the depth and then repeat
> the computation everytime outline-mode requests the level, but it seems
> better to compute it only once, and also calling it something other than
> :depth, since they're not really the same thing.
I've just sent a new version of the patch (v8) in a separate email,
addressing (i think) most of the low-hanging fruit in your review,
David. The parts missing are those needing work, i am afraid: better
documentation and tests.
HTH,
jao
--
The effort to understand the universe is one of the very few things
which lifts human life a little above the level of farce and gives it
some of the grace of tragedy. - Steven Weinberg
next prev parent reply other threads:[~2022-12-13 2:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 23:52 [PATCH v7 0/1] emacs: notmuch-tree-outline-mode jao
2022-11-04 23:52 ` [PATCH v7 1/1] " jao
2022-12-04 16:18 ` David Bremner
2022-12-11 18:24 ` David Bremner
2022-12-11 19:44 ` jao
2022-12-12 13:40 ` David Bremner
2022-12-12 15:22 ` Jose A. Ortega Ruiz
2022-12-12 15:39 ` Jose A. Ortega Ruiz
2022-12-12 16:06 ` David Bremner
2022-12-12 21:06 ` Jose A. Ortega Ruiz
2022-12-13 2:19 ` Jose A. Ortega Ruiz [this message]
2022-11-05 0:01 ` [PATCH v7 0/1] " Jonathan Wilner
2022-11-07 17:05 ` Matt Armstrong
2022-11-05 0:09 ` jao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsdk82qa.fsf@mail.jao.io \
--to=jao@gnu.org \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).