From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id GAubBWHjl2N4FQAAbAwnHQ (envelope-from ) for ; Tue, 13 Dec 2022 03:28:49 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id yMBxBWHjl2OcTQEA9RJhRA (envelope-from ) for ; Tue, 13 Dec 2022 03:28:49 +0100 Received: from mail.notmuchmail.org (yantan.tethera.net [IPv6:2a01:4f9:c011:7a79::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B298A1005C for ; Tue, 13 Dec 2022 03:28:48 +0100 (CET) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 2B34A5FAE6; Tue, 13 Dec 2022 02:19:34 +0000 (UTC) Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by mail.notmuchmail.org (Postfix) with ESMTPS id 8972B5F3CE for ; Tue, 13 Dec 2022 02:19:31 +0000 (UTC) Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4utF-0005e7-UQ; Mon, 12 Dec 2022 21:19:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=UVwcarO2f/61vLpLsaf9ESKHMrdS8zZSTDWOt0gYNJA=; b=dMRgKh6VQBKpjCLNrHXV qXZ4F9w3+kLZ/+DE8PwCPKYrodMO1ZGVTyxpT8JqmqSIHnM//uz2IkhBu+Ge21e73mnsM5PDrqAox SJgDNQRfuidzl1cP8V7QcVGCdCrFpXvwxjX8xtRYewKLLYt5/fqGm5whJTAvYl4UY6KvQGemVXKt4 tq6sNv8ib+6AWRh8auF5U3TvEeZ5IZi/Pb5/cbw3mKFjTecb/QlA4iH1KvVRQlE1rxnUXrXjskope tyTmJ/Y4u/b8bIILgBqtWe8ufBAeCp/pPD+PwUM7rfEri4IGoIuKwg2gVLbam7mmaQq9TrxHj8rDA y1xASRxK5rO9Cw==; Received: from cpc103048-sgyl39-2-0-cust502.18-2.cable.virginm.net ([92.233.85.247] helo=rivendell.localdomain) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4utF-0002b8-BA; Mon, 12 Dec 2022 21:19:29 -0500 Received: from localhost (rivendell.localdomain [local]) by rivendell.localdomain (OpenSMTPD) with ESMTPA id 42d8a12f; Tue, 13 Dec 2022 02:19:25 +0000 (UTC) From: "Jose A. Ortega Ruiz" To: David Bremner Subject: Re: [PATCH v7 1/1] emacs: notmuch-tree-outline-mode In-Reply-To: <87r0x48h71.fsf@mail.jao.io> (Jose A. Ortega Ruiz's message of "Mon, 12 Dec 2022 21:06:58 +0000") References: <20221104235229.515204-1-jao@gnu.org> <20221104235229.515204-2-jao@gnu.org> <87v8mhhk83.fsf@tethera.net> <87ilih4tf5.fsf@mail.jao.io> <87bko8hh9z.fsf@tethera.net> <87r0x48h71.fsf@mail.jao.io> User-Agent: Gnus/5.13 (Gnus v5.13) X-Attribution: jao X-Clacks-Overhead: GNU Terry Pratchett X-URL: Date: Tue, 13 Dec 2022 02:19:25 +0000 Message-ID: <87fsdk82qa.fsf@mail.jao.io> MIME-Version: 1.0 Message-ID-Hash: 2WJI7QUQZWTGTRNVUOC3PJA77TZYPCM3 X-Message-ID-Hash: 2WJI7QUQZWTGTRNVUOC3PJA77TZYPCM3 X-MailFrom: jao@gnu.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: notmuch@notmuchmail.org X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Country: DE X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1670898529; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=+DFPXqGlyAyPNFF043FqBw72zpf0gO9lSv9RALtZXw0=; b=DgsZJKrMBdSoLYR/8TF+/cp3omMlY69++ZvzhHbKyLFbOq6bHtuNKvjDmnLpB5OMvDonJL exedE2c2xb0X9tD1kt6nBGYsGI1KIXOEPnsKq19IMRasQdCuIHCfIWwChLnaCxeox5jzQy ENGnMrAbE9Q9AdmrI9eALfOMRcctK9NVB5WNy4ynomTzIkZamx0VHmKt45UteQli41Pw6y 5ayccTFkdCLY5X8igOIMuiDUxg0N33/lTUaJNesudIQmTRHalwFxaIqMYuCwMq/KPT9jq8 mHO+sz7w9iA/zl8dcvC/5SHKwCZEXBRGfOw7oFy/sCvA1NUDUgVNCU0Rr9RRTA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=gnu.org header.s=fencepost-gnu-org header.b=dMRgKh6V; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gnu.org (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1670898529; a=rsa-sha256; cv=none; b=B8fSRSPf8I8d24QX1LFu2AMt0BcOtQ+l8cWQTnt6QoMuIMkjVm5qEWwitbrrPdNeLSybgG +VWP8G0alVayvA8zq5jqfvYTkIVoI9HYkCZnMPmbvgvOoc53fSxc+O5JRLz7cvY8Q7VKjX 0sKZUzhnL43HYMZS/sOBYPnsZZfQKmURstj+ElYU79lA8DByIuFmRNzdzKIYhxeq1UttVP QW9QzzUzN0uXGPzQzvkHMGmcCa85YlX/6l4k98Ba6bziuLUIk7Lfm2Eo/8iYUS2gGjF3OH LH5AEhma2PG6Hma0SpWMoi4PBKYPFrbCLjPWK5ZvHWiE1wVrL78KfP+S/IiTBA== X-Migadu-Spam-Score: -0.79 X-Spam-Score: -0.79 X-Migadu-Queue-Id: B298A1005C X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=gnu.org header.s=fencepost-gnu-org header.b=dMRgKh6V; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gnu.org (policy=none) X-TUID: 8zkfpdN2BFKs On Mon, Dec 12 2022, Jose A. Ortega Ruiz wrote: > took a second look, and yes, it's close but not quite. there are cases > (when the message is not the first but its depth is 0) where its outline > level doesn't match the depth. we could store the depth and then repeat > the computation everytime outline-mode requests the level, but it seems > better to compute it only once, and also calling it something other than > :depth, since they're not really the same thing. I've just sent a new version of the patch (v8) in a separate email, addressing (i think) most of the low-hanging fruit in your review, David. The parts missing are those needing work, i am afraid: better documentation and tests. HTH, jao -- The effort to understand the universe is one of the very few things which lifts human life a little above the level of farce and gives it some of the grace of tragedy. - Steven Weinberg