Re: [PATCH v7 1/1] emacs: notmuch-tree-outline-mode

[David Bremner <david@tethera.net>]

jao <jao@gnu.org> writes:
>
> diff --git a/doc/notmuch-emacs.rst b/doc/notmuch-emacs.rst
> index 846f5e67..b5f88a98 100644
> --- a/doc/notmuch-emacs.rst
> +++ b/doc/notmuch-emacs.rst
> @@ -606,6 +606,29 @@ can be controlled by the variable ``notmuch-search-oldest-first``.
>     See also :el:defcustom:`notmuch-search-result-format` and
>     :el:defcustom:`notmuch-unthreaded-result-format`.
>  
> +It is also possible to enable outlines in notmuch tree buffers, via
> +``notmuch-tree-outline-mode``.
> +

I'm looking at the HTML output (I guess it's similar in the info output)
and I think this probably needs a sub-heading 


> +|docstring::notmuch-tree-outline-mode|

Unfortunately the more ambitious docstrings don't really transfer across
to rst. Probably it is easier to write a new blurb rather than fix the tooling.

I also felt like I wasn't really clear on what to do with the minor mode
from the docstring.

>  
> diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el
> index b3c2c992..47bd17bc 100644
> --- a/emacs/notmuch-tree.el
> +++ b/emacs/notmuch-tree.el
> @@ -1034,6 +1034,8 @@ message together with all its descendents."
>      (setq msg (plist-put msg :first (and first (eq 0 depth))))
>      (setq msg (plist-put msg :tree-status tree-status))
>      (setq msg (plist-put msg :orig-tags (plist-get msg :tags)))
> +    (setq msg (plist-put msg
> +			 :level (1+ (if (and (eq 0 depth) (not first)) 1
> depth))))

Probably I'm just being lazy, but it would be nice to have a comment
here why level is needed in addition to depth.

more later, I hope...

d