From: David Bremner <david@tethera.net>
To: Daniel Kahn Gillmor <dkg@debian.org>,
michaeljgruber+grubix+git@gmail.com, notmuch@notmuchmail.org
Cc: Michael J Gruber <git@grubix.eu>
Subject: Re: [PATCH v2 2/2] test/smime: fix signature verification test with newer gmime.
Date: Wed, 13 Apr 2022 08:28:47 -0300 [thread overview]
Message-ID: <87ee21b4sw.fsf@tethera.net> (raw)
In-Reply-To: <87sfqhlw8b.fsf@fifthhorseman.net>
Daniel Kahn Gillmor <dkg@debian.org> writes:
> Thanks, Michael--
>
> This LGTM.
>
> It is more narrowly-targeted at permitting this specific variation than
> Bremner's earlier version of the patch (and it doesn't have any tests
> marked BROKEN), which is nice.
>
> It might be marginally cleaner to swap out the LEFT_ANGLE RIGHT_ANGLE
> variables for a single replacement variable like so:
>
> if [ $NOTMUCH_GMIME_EMITS_ANGLE_BRACKETS == 1 ]; then
> EXPECTED_EMAIL_ADDR='<test_suite@notmuchmail.org>'
> else
> EXPECTED_EMAIL_ADDR='test_suite@notmuchmail.org'
> fi
In the end I applied this version to master. Thanks to you both.
d
prev parent reply other threads:[~2022-04-13 11:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-18 10:48 Failing notmuch/SMIME test David Bremner
2022-03-20 21:10 ` Daniel Kahn Gillmor
2022-03-22 17:16 ` David Bremner
2022-04-09 12:34 ` [PATCH 1/2] configure: restructure gmime cert validity checker code David Bremner
2022-04-09 12:34 ` [PATCH 2/2] test/smime: fix signature verification test with newer gmime David Bremner
2022-04-11 0:35 ` Daniel Kahn Gillmor
2022-04-11 8:44 ` Michael J Gruber
2022-04-11 21:53 ` Daniel Kahn Gillmor
2022-04-12 20:15 ` [PATCH v2 " michaeljgruber+grubix+git
2022-04-12 23:26 ` Daniel Kahn Gillmor
2022-04-13 11:28 ` David Bremner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ee21b4sw.fsf@tethera.net \
--to=david@tethera.net \
--cc=dkg@debian.org \
--cc=git@grubix.eu \
--cc=michaeljgruber+grubix+git@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).