From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 8CU7JvezVmKQ1gAAgWs5BA (envelope-from ) for ; Wed, 13 Apr 2022 13:28:55 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 2HiRIvezVmLINAEA9RJhRA (envelope-from ) for ; Wed, 13 Apr 2022 13:28:55 +0200 Received: from mail.notmuchmail.org (yantan.tethera.net [135.181.149.255]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4877A3EA4A for ; Wed, 13 Apr 2022 13:28:55 +0200 (CEST) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id E0CA75F72B; Wed, 13 Apr 2022 11:28:52 +0000 (UTC) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by mail.notmuchmail.org (Postfix) with ESMTP id 54EE95F6C9 for ; Wed, 13 Apr 2022 11:28:50 +0000 (UTC) Received: by fethera.tethera.net (Postfix, from userid 1001) id 3AEFB5FBD7; Wed, 13 Apr 2022 07:28:49 -0400 (EDT) Received: (nullmailer pid 2958428 invoked by uid 1000); Wed, 13 Apr 2022 11:28:47 -0000 From: David Bremner To: Daniel Kahn Gillmor , michaeljgruber+grubix+git@gmail.com, notmuch@notmuchmail.org Subject: Re: [PATCH v2 2/2] test/smime: fix signature verification test with newer gmime. In-Reply-To: <87sfqhlw8b.fsf@fifthhorseman.net> References: <87mtgrmgll.fsf@fifthhorseman.net> <458b1d99c3d868d4c1659b29d0aa4474aff215c1.1649781229.git.git@grubix.eu> <87sfqhlw8b.fsf@fifthhorseman.net> Date: Wed, 13 Apr 2022 08:28:47 -0300 Message-ID: <87ee21b4sw.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: FS5SZTJ5WXX7ZAJ4PCVLJZ2HHHNAXE5B X-Message-ID-Hash: FS5SZTJ5WXX7ZAJ4PCVLJZ2HHHNAXE5B X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Michael J Gruber X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: DE ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1649849335; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post; bh=JUsjOo/MKJ9HxH8UMQ1k0j0QnAJcoNR61GOutiN3/M4=; b=oxOYLktPSMor//Nj4XgmcwDYuudjWb3T4itFc+kXeRQ5cdfAExZf4Kgjo+vPi/0MmBcIR3 GMHvS9ian6YcPpkw/oOFFNYnWNx1EpNrU4MPvq2EF+sIz+y8QTrNwttc+1hsVYxf3kReUz e4U3Urylr2sP7GZ0X5tOHf1K5mll+CINd0Dp5IIqjSU626Iow0tZVtkVHf9iFyM+/gZPpM iRCmzAI5yhoEIQeuSby+vlunU7icCB1SQoNpwN5lcReqNxkST+9Qx2rFlAnQdTDdSlJKX7 4e5DMyIuFtUqqk2h73J6++m4Tp0GPwV7LxN16Qiwd9ZkQgFkSgPdUTiXbhf+5A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1649849335; a=rsa-sha256; cv=none; b=Fr8yb4ToQdpQX1YRDDm4UtRPtt8L0OHG2dyW5i8hA6wH/D/qtlecMEpqASFtAMMkKjYmUE u+hDmzwbz2GAbotXwgQ83g2YjbCJWsp1fENyEe1V279ZFUcbp1+Clc8JDc2RTBiChCFym6 8+qJ8Cbs9hmZ4+oYD7kPwQtteS9TxaoPn4dvY2xxTFUoYvKDfXkXJqMtDJvvw7HRNmYP/u vSloOTsT76/JmQzWYcC/+zKuiKRa/+Kom8JwhKeSFWdPc6q3DqAKB5cq30LfC5tZFjAejp uqWeRrWMXNe7ptW8rhlvA3gdjgjD1maskNaaZMSIwTBkOtf7d7oxPpzNl0I3lQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -0.70 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 4877A3EA4A X-Spam-Score: -0.70 X-Migadu-Scanner: scn0.migadu.com X-TUID: v+QDjAsL0Uxj Daniel Kahn Gillmor writes: > Thanks, Michael-- > > This LGTM. > > It is more narrowly-targeted at permitting this specific variation than > Bremner's earlier version of the patch (and it doesn't have any tests > marked BROKEN), which is nice. > > It might be marginally cleaner to swap out the LEFT_ANGLE RIGHT_ANGLE > variables for a single replacement variable like so: > > if [ $NOTMUCH_GMIME_EMITS_ANGLE_BRACKETS == 1 ]; then > EXPECTED_EMAIL_ADDR='' > else > EXPECTED_EMAIL_ADDR='test_suite@notmuchmail.org' > fi In the end I applied this version to master. Thanks to you both. d