From: David Bremner <david@tethera.net>
To: Daniel Kahn Gillmor <dkg@debian.org>, notmuch@notmuchmail.org
Subject: Re: Failing notmuch/SMIME test
Date: Tue, 22 Mar 2022 13:16:09 -0400 [thread overview]
Message-ID: <874k3pvrfq.fsf@tethera.net> (raw)
In-Reply-To: <875yo8nxd0.fsf@fifthhorseman.net>
Daniel Kahn Gillmor <dkg@debian.org> writes:
> I suppose the right way to fix this generically is a test which
> abstracts out whether gmime reports an angle-addr or a addr-spec for
> x.509 certs, and then adjust the tests to match.
>
> I can try to send a patch for this, but it'll take me a while to swap
> it all back in.
>
> If anyone wants to propose a patch in the meantime, i'd also be happy to
> review.
>
> The simplest thing in the short term is probably to switch the test to
> matching based on the bare e-mail address and assert a build-dep on
> gmime 3.2.8 (see attached), but that seems a little bit extreme, since
> gmime only released 3.2.9 recently (and 3.2.8 never made it out the door
> via any formal channels, if i understand the history correctly).
What do you think about accepting both with < > and without, via some
"sanitize" function? Or just marking the test broken for old gmime. I
think we do something like the latter in some places.
d
next prev parent reply other threads:[~2022-03-22 17:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-18 10:48 Failing notmuch/SMIME test David Bremner
2022-03-20 21:10 ` Daniel Kahn Gillmor
2022-03-22 17:16 ` David Bremner [this message]
2022-04-09 12:34 ` [PATCH 1/2] configure: restructure gmime cert validity checker code David Bremner
2022-04-09 12:34 ` [PATCH 2/2] test/smime: fix signature verification test with newer gmime David Bremner
2022-04-11 0:35 ` Daniel Kahn Gillmor
2022-04-11 8:44 ` Michael J Gruber
2022-04-11 21:53 ` Daniel Kahn Gillmor
2022-04-12 20:15 ` [PATCH v2 " michaeljgruber+grubix+git
2022-04-12 23:26 ` Daniel Kahn Gillmor
2022-04-13 11:28 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874k3pvrfq.fsf@tethera.net \
--to=david@tethera.net \
--cc=dkg@debian.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).