From: Floris Bruynooghe <flub@devork.be>
To: David Bremner <david@tethera.net>,
Lele Gaifax <lele@metapensiero.it>,
notmuch@notmuchmail.org
Subject: Re: [PATCH] bindings/python-cffi: search for config by default
Date: Sat, 08 Jan 2022 19:47:55 +0100 [thread overview]
Message-ID: <87czl2awtg.fsf@powell.devork.be> (raw)
In-Reply-To: <20220108161913.3117598-1-david@tethera.net>
On Sat 08 Jan 2022 at 12:19 -0400, David Bremner wrote:
> The previous (pre-0.34.2) constructor searched for a config file but
> only if the database path was not specified, and only to retrieve
> database.path. Neither of the available options (CONFIG.SEARCH or
> CONFIG.NONE) matches this semantics exactly, but CONFIG.SEARCH causes
> less breakage for people who relied on the old behaviour to set their
> database.path [1]. Since it also seems like the friendlier option in
> the long run, this commit switches to CONFIG.SEARCH as default.
>
> [1]: id:87fsqijx7u.fsf@metapensiero.it
> ---
> bindings/python-cffi/notmuch2/_database.py | 2 +-
> bindings/python-cffi/tests/test_database.py | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/bindings/python-cffi/notmuch2/_database.py b/bindings/python-cffi/notmuch2/_database.py
> index 14a8f15c..d7485b4d 100644
> --- a/bindings/python-cffi/notmuch2/_database.py
> +++ b/bindings/python-cffi/notmuch2/_database.py
> @@ -139,7 +139,7 @@ class Database(base.NotmuchObject):
> path = os.fsencode(path)
> return path
>
> - def __init__(self, path=None, mode=MODE.READ_ONLY, config=CONFIG.EMPTY):
> + def __init__(self, path=None, mode=MODE.READ_ONLY, config=CONFIG.SEARCH):
> if isinstance(mode, str):
> mode = self.STR_MODE_MAP[mode]
> self.mode = mode
> diff --git a/bindings/python-cffi/tests/test_database.py b/bindings/python-cffi/tests/test_database.py
> index 9b3219c0..473723d5 100644
> --- a/bindings/python-cffi/tests/test_database.py
> +++ b/bindings/python-cffi/tests/test_database.py
> @@ -13,7 +13,7 @@ import notmuch2._message as message
>
> @pytest.fixture
> def db(maildir):
> - with dbmod.Database.create(maildir.path) as db:
> + with dbmod.Database.create(maildir.path, config=notmuch2.Database.CONFIG.SEARCH) as db:
> yield db
LGTM
next prev parent reply other threads:[~2022-01-08 18:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-24 7:09 Python notmuch2 bridge, something changed in the Database constructor Lele Gaifax
2021-12-24 13:03 ` David Bremner
2021-12-24 13:42 ` Lele Gaifax
2022-01-01 15:20 ` Floris Bruynooghe
2022-01-08 16:19 ` [PATCH] bindings/python-cffi: search for config by default David Bremner
2022-01-08 18:47 ` Floris Bruynooghe [this message]
2022-01-08 21:21 ` [PATCH v2] " David Bremner
2022-01-09 20:00 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87czl2awtg.fsf@powell.devork.be \
--to=flub@devork.be \
--cc=david@tethera.net \
--cc=lele@metapensiero.it \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).