From: David Bremner <david@tethera.net>
To: notmuch@notmuchmail.org
Subject: Re: [PATCH v2] bindings/python-cffi: search for config by default
Date: Sun, 09 Jan 2022 16:00:59 -0400 [thread overview]
Message-ID: <87tuecsmpw.fsf@tethera.net> (raw)
In-Reply-To: <20220108212143.3417678-1-david@tethera.net>
David Bremner <david@tethera.net> writes:
> The previous (pre-0.34.2) constructor searched for a config file but
> only if the database path was not specified, and only to retrieve
> database.path. Neither of the available options (CONFIG.SEARCH or
> CONFIG.NONE) matches this semantics exactly, but CONFIG.SEARCH causes
> less breakage for people who relied on the old behaviour to set their
> database.path [1]. Since it also seems like the friendlier option in
> the long run, this commit switches to CONFIG.SEARCH as default.
applied the fixed version to master and release. For some reason I only
tested the original version by running pytest, but the notmuch test
suite actually sets up an environment where the code is run without a
config file, and that failed in the initial version.
d
prev parent reply other threads:[~2022-01-09 20:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-24 7:09 Python notmuch2 bridge, something changed in the Database constructor Lele Gaifax
2021-12-24 13:03 ` David Bremner
2021-12-24 13:42 ` Lele Gaifax
2022-01-01 15:20 ` Floris Bruynooghe
2022-01-08 16:19 ` [PATCH] bindings/python-cffi: search for config by default David Bremner
2022-01-08 18:47 ` Floris Bruynooghe
2022-01-08 21:21 ` [PATCH v2] " David Bremner
2022-01-09 20:00 ` David Bremner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tuecsmpw.fsf@tethera.net \
--to=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).