unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Floris Bruynooghe <flub@devork.be>
To: David Bremner <david@tethera.net>,
	Lele Gaifax <lele@metapensiero.it>,
	notmuch@notmuchmail.org
Subject: Re: Python notmuch2 bridge, something changed in the Database constructor
Date: Sat, 01 Jan 2022 16:20:11 +0100	[thread overview]
Message-ID: <87bl0vlbys.fsf@powell.devork.be> (raw)
In-Reply-To: <87lf0anoiv.fsf@tethera.net>

On Fri 24 Dec 2021 at 09:03 -0400, David Bremner wrote:
>
> @Floris: when I made the change to the Database constructor, I chose the
> default as CONFIG.NONE because this matched the previous semantics
> _except_ for finding the database path. But since I don't want to use
> the ad hoc default_path method anymore, maybe a better default would be
> CONFIG.SEARCH. I guess most users of the python bindings will be OK with
> the the configuration values in .notmuch-config being loaded by default.
> What do you think?

Originally my intention with opening the database was that doing the
same as notmuch itself does by default would be the default and most
natural thing to do (whether or not I succeeded at the time I have no
idea).  So reading .notmuch-config by default and using it correctly
seems fine to me.  Backwards compatibility is always tricky I guess, but
following notmuch's behaviour itself seems reasonable to me.

As a random data point I just checked my own use and I seem to be
passing the database path explicitly.


Cheers,
Floris

  parent reply	other threads:[~2022-01-01 15:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-24  7:09 Python notmuch2 bridge, something changed in the Database constructor Lele Gaifax
2021-12-24 13:03 ` David Bremner
2021-12-24 13:42   ` Lele Gaifax
2022-01-01 15:20   ` Floris Bruynooghe [this message]
2022-01-08 16:19 ` [PATCH] bindings/python-cffi: search for config by default David Bremner
2022-01-08 18:47   ` Floris Bruynooghe
2022-01-08 21:21     ` [PATCH v2] " David Bremner
2022-01-09 20:00       ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bl0vlbys.fsf@powell.devork.be \
    --to=flub@devork.be \
    --cc=david@tethera.net \
    --cc=lele@metapensiero.it \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).