* [PATCH] emacs: tree: bugfix: specify --format-version
@ 2017-04-15 15:50 Mark Walters
2017-05-13 12:00 ` David Bremner
0 siblings, 1 reply; 2+ messages in thread
From: Mark Walters @ 2017-04-15 15:50 UTC (permalink / raw)
To: notmuch, david
Previously notmuch tree did not specify the format-version when
calling notmuch. This meant that when the structured output was
slightly changed (in commit 14c60cf168ac3b0f277188c16e6012b7ebdadde7)
stash filename broke. This fixes this breakage by specifying the
format-version.
---
Bremner pointed out this bug today on irc. In due course we may want
to use format-version=3 and update the helper functions but as none of
notmuch-emacs uses the new format version yet this seem the right fix for now.
Best wishes
Mark
emacs/notmuch-tree.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el
index 7bebdba..d4d4076 100644
--- a/emacs/notmuch-tree.el
+++ b/emacs/notmuch-tree.el
@@ -917,7 +917,7 @@ the same as for the function notmuch-tree."
(notmuch-tag-clear-cache)
(let ((proc (notmuch-start-notmuch
"notmuch-tree" (current-buffer) #'notmuch-tree-process-sentinel
- "show" "--body=false" "--format=sexp"
+ "show" "--body=false" "--format=sexp" "--format-version=2"
message-arg search-args))
;; Use a scratch buffer to accumulate partial output.
;; This buffer will be killed by the sentinel, which
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] emacs: tree: bugfix: specify --format-version
2017-04-15 15:50 [PATCH] emacs: tree: bugfix: specify --format-version Mark Walters
@ 2017-05-13 12:00 ` David Bremner
0 siblings, 0 replies; 2+ messages in thread
From: David Bremner @ 2017-05-13 12:00 UTC (permalink / raw)
To: Mark Walters, notmuch; +Cc: Mark Walters, notmuch
Mark Walters <markwalters1009@gmail.com> writes:
> Previously notmuch tree did not specify the format-version when
> calling notmuch. This meant that when the structured output was
> slightly changed (in commit 14c60cf168ac3b0f277188c16e6012b7ebdadde7)
> stash filename broke. This fixes this breakage by specifying the
> format-version.
> ---
>
> Bremner pointed out this bug today on irc. In due course we may want
> to use format-version=3 and update the helper functions but as none of
> notmuch-emacs uses the new format version yet this seem the right fix for now.
Pushed to release and master.
collecting bug fixes for a potential 0.24.2
d
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-05-13 12:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-15 15:50 [PATCH] emacs: tree: bugfix: specify --format-version Mark Walters
2017-05-13 12:00 ` David Bremner
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).