From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 7CE566DE1342 for ; Sat, 15 Apr 2017 08:50:04 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -1.043 X-Spam-Level: X-Spam-Status: No, score=-1.043 tagged_above=-999 required=5 tests=[AWL=-1.173, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lhBe0c5Qg9dL for ; Sat, 15 Apr 2017 08:50:04 -0700 (PDT) Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by arlo.cworth.org (Postfix) with ESMTPS id 935AA6DE133D for ; Sat, 15 Apr 2017 08:50:03 -0700 (PDT) Received: by mail-wm0-f68.google.com with SMTP id q125so2811174wmd.3 for ; Sat, 15 Apr 2017 08:50:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=A5xYY5pJOgwjcYYcfJUPf+1X8wWsQkKDNCHViD5X8MI=; b=DRjd/accu7zdgVO45QsF5t+1GeuuSIyslCuYVGIgIo1YHOG71zgFsH7fv8NBDiy/az wytXYLa8zlQ4dYrknxDPvbdVFLrOQK3P6m07uCssaIwXpC4qfodVmsAnqoNgnC4N0p89 Rjr9uW+EnsGvAHo0f7ak2TnMNerulHfuRzgg2CPBhuaSnpyqA5v5dtv/LdekZNK78J2d OArTncwRlSYujyKhMA4P+LWtTAr7gm9fzv0KjGEVqkwznXdK6zPp8VnR3ar79Qz6iQTb iXB9gmNx8B0kB+EEMeqLtoXIbbGQV8dX48jpXUxGmcLE8YQN83E1HYMhean5lZL7Fe/B 866Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=A5xYY5pJOgwjcYYcfJUPf+1X8wWsQkKDNCHViD5X8MI=; b=I/K439s5R49dNi7HbNtiVN2MYxdZDeV6XJWLHkf5yiGb28qmz8orEA/hdK3hE4CeEc 3tqLWvMNjtcV99mrx1LNhUFBQk1V10PGJ9Zf8Z7xEZ0NHrNgTu0Pl7knzwpyMy8L1xbc d6TiFZauhlUCk6DoFy0KPPjuro6h79c6QGOa6io25QerUxRdQfVskqQLBHx8zBvYMzJI Wymi7dPgZ4cuKM04KjDxa+rf4iInjck2aZfE4L05m0r/dtpD6XFf0018PPgsDtBQcfR4 RZgVdoQLPbgfLwOKIXw+7gCac+zdyfpFcgIyWJiBkqwAlmDH3L6k+vW3/RctIdwMigwV JDRA== X-Gm-Message-State: AN3rC/7VgvdAbRfmxa7N6y6Plg1OQJ2RItAjnmPp5eQ3EbNlTFt94Srr doLq7Xdl59G5MQ== X-Received: by 10.28.11.69 with SMTP id 66mr3093059wml.38.1492271401723; Sat, 15 Apr 2017 08:50:01 -0700 (PDT) Received: from localhost (94.197.182.109.threembb.co.uk. [94.197.182.109]) by smtp.gmail.com with ESMTPSA id o77sm6844179wrc.38.2017.04.15.08.50.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 15 Apr 2017 08:50:00 -0700 (PDT) From: Mark Walters To: notmuch@notmuchmail.org, david@tethera.net Subject: [PATCH] emacs: tree: bugfix: specify --format-version Message-Id: <1492271386-12665-1-git-send-email-markwalters1009@gmail.com> X-Mailer: git-send-email 2.1.4 X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Sat, 15 Apr 2017 15:50:04 -0000 X-Original-Date: Sat, 15 Apr 2017 16:49:46 +0100 X-List-Received-Date: Sat, 15 Apr 2017 15:50:04 -0000 Previously notmuch tree did not specify the format-version when calling notmuch. This meant that when the structured output was slightly changed (in commit 14c60cf168ac3b0f277188c16e6012b7ebdadde7) stash filename broke. This fixes this breakage by specifying the format-version. --- Bremner pointed out this bug today on irc. In due course we may want to use format-version=3 and update the helper functions but as none of notmuch-emacs uses the new format version yet this seem the right fix for now. Best wishes Mark emacs/notmuch-tree.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el index 7bebdba..d4d4076 100644 --- a/emacs/notmuch-tree.el +++ b/emacs/notmuch-tree.el @@ -917,7 +917,7 @@ the same as for the function notmuch-tree." (notmuch-tag-clear-cache) (let ((proc (notmuch-start-notmuch "notmuch-tree" (current-buffer) #'notmuch-tree-process-sentinel - "show" "--body=false" "--format=sexp" + "show" "--body=false" "--format=sexp" "--format-version=2" message-arg search-args)) ;; Use a scratch buffer to accumulate partial output. ;; This buffer will be killed by the sentinel, which -- 2.1.4