[PATCH] emacs: don't start processes stopped

* [PATCH] emacs: don't start processes stopped
@ 2020-01-03 17:04 Steven Allen
  2020-01-03 23:17 ` David Edmondson
  2020-01-09  1:28 ` David Bremner
  0 siblings, 2 replies; 4+ messages in thread
From: Steven Allen @ 2020-01-03 17:04 UTC (permalink / raw)
  To: notmuch

It causes this function to fail with:

    let: Wrong type argument: null, t

Support for this was removed from Emacs in April
2019 (5c5e309527e6b582e2c04b83e7af45f3144863ac) because it never
worked correctly (apparently).

This also shouldn't be necessary as sentinels will not be called
unless emacs is idle or waiting for input. Therefore, the
`process-put' calls immediately following the `make-process' call
should always complete before the sentinel is first called.
---
 emacs/notmuch-crypto.el | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/emacs/notmuch-crypto.el b/emacs/notmuch-crypto.el
index f4585d5e..4035ee37 100644
--- a/emacs/notmuch-crypto.el
+++ b/emacs/notmuch-crypto.el
@@ -222,16 +222,11 @@ corresponding key when the status button is pressed."
 				 :buffer buffer
 				 :stderr buffer
 				 :command (list notmuch-crypto-gpg-program "--recv-keys" keyid)
-				 :sentinel #'notmuch-crypto--async-key-sentinel
-				 ;; Create the process stopped so that
-				 ;; we have time to store the key id,
-				 ;; etc. on it.
-				 :stop t)))
+				 :sentinel #'notmuch-crypto--async-key-sentinel)))
 	    (process-put p :gpg-key-id keyid)
 	    (process-put p :notmuch-show-buffer (current-buffer))
 	    (process-put p :notmuch-show-point (point))
-	    (message "Getting the GPG key %s asynchronously..." keyid)
-	    (continue-process p)))
+	    (message "Getting the GPG key %s asynchronously..." keyid)))
 
       (let ((window (display-buffer buffer)))
 	(with-selected-window window
-- 
2.24.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread