From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 2ECE66DE0F34 for ; Fri, 3 Jan 2020 15:17:31 -0800 (PST) Authentication-Results: arlo.cworth.org; dkim=pass (2048-bit key; unprotected) header.d=dme-org.20150623.gappssmtp.com header.i=@dme-org.20150623.gappssmtp.com header.b="DbWXysG/"; dkim-atps=neutral X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0.245 X-Spam-Level: X-Spam-Status: No, score=0.245 tagged_above=-999 required=5 tests=[AWL=-0.407, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_NEUTRAL=0.652, UNPARSEABLE_RELAY=0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0rkBr4fiyo_r for ; Fri, 3 Jan 2020 15:17:30 -0800 (PST) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by arlo.cworth.org (Postfix) with ESMTPS id AF3C36DE0F27 for ; Fri, 3 Jan 2020 15:17:29 -0800 (PST) Received: by mail-wr1-f67.google.com with SMTP id c9so43822833wrw.8 for ; Fri, 03 Jan 2020 15:17:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dme-org.20150623.gappssmtp.com; s=20150623; h=to:subject:in-reply-to:references:from:date:message-id:mime-version; bh=Mj6VU81f80fIsl5YOtovrgvCo5148FYkbbt8L+uxCE4=; b=DbWXysG/IqxAXWJVM5Hm+EJ02AB+6x1R6S5LNh32ikTNdFzOYgitsTOc9x5JVVPrxn iNnfBBM9779MQmYhLn1gMfomLVPLfEPmu2XsCWaxDg399xSegKd7i2uzTYyYb2Owr3xE ViomO299/zhW2SwUL4CzarL1YoykBYbf/I8ApgatwWpDKi78H6WsMPVXyxlJ2kZxbYPf be+KdmUTAEzyoaavUHa1i+F9umBVFg5G50ln7g8va/9GqMcHmnGLxJYEKk25w3H0BqBI MBzs8EPg4gZshzFzSfDIlQcvALr4m9Rr7AufMjBb61qiGYf4LdJC15H3ztiZw6z70gqY gxkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:subject:in-reply-to:references:from:date :message-id:mime-version; bh=Mj6VU81f80fIsl5YOtovrgvCo5148FYkbbt8L+uxCE4=; b=ADTw00wGjcUOwD/UL+ISCcDr73BplE7qucnDThXbNWjQJBbGLAkHwPRk9knHBG8hdO PyKa3wIskQyh1nZ55Cth6WaNcpG7BSj8JmzHim6TLmuAEUbJSVQxaKDEo5hEtpEKRa6n 7McCe7MpSmnnGPd/46ZefDMUBEcCtK8pkJtyzHUULWuvtQNp8pns44t1cwkREmI2JbwC FbMd5zunzT/wTfFUE1Oa6l7Hzc28rcQZehqLNAnGGajn63UUbDLOH05cWnyY3qabb/Tb Z5tjToidixROtJjd+4EGdPpy8/YWLw9+HQx2R1yrxLenZRnO1qi/ZMxbsWsSxEv4CfnC hhuw== X-Gm-Message-State: APjAAAVEe0yfWI/WGTWq7nX03w/n8EaJU+8oTwtokHBGtG8XjPiqt1JJ dPIXdcDIrIlguQp6BDkwidrwNw== X-Google-Smtp-Source: APXvYqzid1FLS0ixqL4GGdVRm53aFabt9a//YDY+0Pn2CkzS6dRX+osFcHHVsxNtzQGdraWBbpMscA== X-Received: by 2002:adf:ea4e:: with SMTP id j14mr93162907wrn.101.1578093445927; Fri, 03 Jan 2020 15:17:25 -0800 (PST) Received: from disaster-area.hh.sledj.net (disaster-area.hh.sledj.net. [81.149.164.25]) by smtp.gmail.com with ESMTPSA id t81sm14043279wmg.6.2020.01.03.15.17.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jan 2020 15:17:24 -0800 (PST) Received: from localhost (disaster-area.hh.sledj.net [local]) by disaster-area.hh.sledj.net (OpenSMTPD) with ESMTPA id b25ff405; Fri, 3 Jan 2020 23:17:24 +0000 (UTC) To: Steven Allen , notmuch@notmuchmail.org Subject: Re: [PATCH] emacs: don't start processes stopped In-Reply-To: <20200103170400.15137-1-steven@stebalien.com> References: <20200103170400.15137-1-steven@stebalien.com> X-HGTTG: zarniwoop From: David Edmondson Date: Fri, 03 Jan 2020 23:17:24 +0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jan 2020 23:17:31 -0000 On Friday, 2020-01-03 at 09:04:00 -08, Steven Allen wrote: > It causes this function to fail with: > > let: Wrong type argument: null, t > > Support for this was removed from Emacs in April > 2019 (5c5e309527e6b582e2c04b83e7af45f3144863ac) because it never > worked correctly (apparently). > > This also shouldn't be necessary as sentinels will not be called > unless emacs is idle or waiting for input. Therefore, the > `process-put' calls immediately following the `make-process' call > should always complete before the sentinel is first called. Reviewed-by: David Edmondson > --- > emacs/notmuch-crypto.el | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-) > > diff --git a/emacs/notmuch-crypto.el b/emacs/notmuch-crypto.el > index f4585d5e..4035ee37 100644 > --- a/emacs/notmuch-crypto.el > +++ b/emacs/notmuch-crypto.el > @@ -222,16 +222,11 @@ corresponding key when the status button is pressed." > :buffer buffer > :stderr buffer > :command (list notmuch-crypto-gpg-program "--recv-keys" keyid) > - :sentinel #'notmuch-crypto--async-key-sentinel > - ;; Create the process stopped so that > - ;; we have time to store the key id, > - ;; etc. on it. > - :stop t))) > + :sentinel #'notmuch-crypto--async-key-sentinel))) > (process-put p :gpg-key-id keyid) > (process-put p :notmuch-show-buffer (current-buffer)) > (process-put p :notmuch-show-point (point)) > - (message "Getting the GPG key %s asynchronously..." keyid) > - (continue-process p))) > + (message "Getting the GPG key %s asynchronously..." keyid))) > > (let ((window (display-buffer buffer))) > (with-selected-window window > -- > 2.24.1 > > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > https://notmuchmail.org/mailman/listinfo/notmuch dme. -- We can dance if we want to, we can leave your friends behind.