Emacs and the missing 'g'

Emacs and the missing 'g'

[Matt Armstrong]

I'm returning to notmuch after a hiatus.  It is still nice!

First thing I've noticed: the Emacs modes seem to ignore the 'g' key.  I
would like to bind it (by default) to the relevant "refresh" commands.
I'll explain.

notmuch-hello mode leaves 'b' bound to self-insert-command, and
notmuch-search mode does as well.

Most notmuch modes are "special" modes -- i.e. their text is generated
by Emacs and does not reflect a file.  In these modes 'g' has
traditionally been bound to revert the buffer [1].

You see this across many modes: dired, vc, gnus, etc.

I was actually going to report this as a bug until I realized that
notmuch consistently uses '=' for the same thing.

Any objection to also binding 'g'?


For context, here is the list of other bindings in a "special" mode
(from Emacs' simple.el).  Notmuch already follows some of these (such as
<, > and q).

    SPC             scroll-up-command
    -               negative-argument
    0 .. 9          digit-argument
    <               beginning-of-buffer
    >               end-of-buffer
    ?               describe-mode
    g               revert-buffer
    h               describe-mode
    q               quit-window
    DEL             scroll-down-command
    S-SPC           scroll-down-command

[1] (elisp) Basic Major Modes

Re: Emacs and the missing 'g'

[Carl Worth]

[-- Attachment #1: Type: text/plain, Size: 607 bytes --]

On Tue, Feb 12 2019, Matt Armstrong wrote:
> I'm returning to notmuch after a hiatus.  It is still nice!

Glad to hear it! Welcome back.

> Most notmuch modes are "special" modes -- i.e. their text is generated
> by Emacs and does not reflect a file.  In these modes 'g' has
> traditionally been bound to revert the buffer [1].
...
> Any objection to also binding 'g'?

I have no opposition to this. I wasn't aware of the convention around
'g' when I first did the thing with '=', but I'd be happy to match that
convention to have notmuch feel more like a well-behaved citizen of the
emacs universe.

-Carl

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

Re: Emacs and the missing 'g'

[David Bremner]

Matt Armstrong <marmstrong@google.com> writes:

> I'm returning to notmuch after a hiatus.  It is still nice!
>
> First thing I've noticed: the Emacs modes seem to ignore the 'g' key.  I
> would like to bind it (by default) to the relevant "refresh" commands.
> I'll explain.
>
[snip]
> I was actually going to report this as a bug until I realized that
> notmuch consistently uses '=' for the same thing.
>
> Any objection to also binding 'g'?
>

No objections from me. At some point there was a conflict with some
other binding in notmuch, but I can't find the conflict offhand.

d