From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 4D8RFWAEOmJg6wAAgWs5BA (envelope-from ) for ; Tue, 22 Mar 2022 18:16:16 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id yAkDEmAEOmItdQEA9RJhRA (envelope-from ) for ; Tue, 22 Mar 2022 18:16:16 +0100 Received: from mail.notmuchmail.org (yantan.tethera.net [135.181.149.255]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 213A52FAC9 for ; Tue, 22 Mar 2022 18:16:16 +0100 (CET) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id DE2215F71C; Tue, 22 Mar 2022 17:16:13 +0000 (UTC) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by mail.notmuchmail.org (Postfix) with ESMTP id 641B25F700 for ; Tue, 22 Mar 2022 17:16:10 +0000 (UTC) Received: by fethera.tethera.net (Postfix, from userid 1000) id A17AB5FBD7; Tue, 22 Mar 2022 13:16:09 -0400 (EDT) From: David Bremner To: Daniel Kahn Gillmor , notmuch@notmuchmail.org Subject: Re: Failing notmuch/SMIME test In-Reply-To: <875yo8nxd0.fsf@fifthhorseman.net> References: <87mthn5yfy.fsf@tethera.net> <875yo8nxd0.fsf@fifthhorseman.net> Date: Tue, 22 Mar 2022 13:16:09 -0400 Message-ID: <874k3pvrfq.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: MP5Y52OMKKLFYF5UYJDYFZACYI2CIO5F X-Message-ID-Hash: MP5Y52OMKKLFYF5UYJDYFZACYI2CIO5F X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: DE ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1647969376; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post; bh=mZIqlgiqVQ6oMDlrep+6Ri5cLkxz9sBrdU6J5KhH6GM=; b=tPMHXpwCRKk8WA0Qdu12DCpMXR/gdJfng2Id4kTvw/D1xLnGB4UASKRsDilxO9H3suhTpr cxnhNil86zUk4TziMYecymKHtC6T1lRwhGKJKgGdopmdTnXBuVKkAjF7uGfxIikepC79GT 40GZ94Ak6bZIOloSaEQhYeBTa5DAZ8npl/LgAZf6EJT75dkqUGLfdIpmKqKzKbYZbIEO72 lLbG1EZQJnnQaRd+iRFbvS/BM1sVROsfiDUfo/Ee5+GgMnDMYe2A8MJqTGOFAf+8BO+M+4 H/VlgvVcJT7S8PxmRwF0tM3W9GTyobfXFXVMndDSk+tW61WSOJoy54Udumu07g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1647969376; a=rsa-sha256; cv=none; b=qyz2Vrw6cGhJhXJ4i9i3tN+qih0aIfH8zpHMEj9porKfPDlF8eLPW7wMsgATnI9defKP+7 Om/AykE3gqqpT3NpKsqlTpBAyv/8xTwhmOpS2Z/8M03CaP8jVNVNA27upQCOhIAqaNkZtt BCTC8/evDnxxizzso5SsPy1vQ6Zd/OQlJ0yZnHU5EpxhBoMXwBpfMuVSqBnK1Iq14MLS5L Gwlhe3fluprFrKX1LC23epl+yp6v9Ay5oFk2jonSc+Z707yCxZyuRut7DBQ2p76mdend0U 5WJhb+ajiITbSeMo95MlDhn+Pe9EFTSW6I/V6LHDoZ/XYQMAdgpmGnjhR5m8Yw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -2.17 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 213A52FAC9 X-Spam-Score: -2.17 X-Migadu-Scanner: scn0.migadu.com X-TUID: pQeKRWdoXt3E Daniel Kahn Gillmor writes: > I suppose the right way to fix this generically is a test which > abstracts out whether gmime reports an angle-addr or a addr-spec for > x.509 certs, and then adjust the tests to match. > > I can try to send a patch for this, but it'll take me a while to swap > it all back in. > > If anyone wants to propose a patch in the meantime, i'd also be happy to > review. > > The simplest thing in the short term is probably to switch the test to > matching based on the bare e-mail address and assert a build-dep on > gmime 3.2.8 (see attached), but that seems a little bit extreme, since > gmime only released 3.2.9 recently (and 3.2.8 never made it out the door > via any formal channels, if i understand the history correctly). What do you think about accepting both with < > and without, via some "sanitize" function? Or just marking the test broken for old gmime. I think we do something like the latter in some places. d