From: Tim Bielawa <tbielawa@redhat.com>
To: notmuch@notmuchmail.org
Subject: Re: [PATCH] Fix mml-quoting in responses where pgp-signing is enabled
Date: Sat, 03 Mar 2012 18:17:19 -0500 [thread overview]
Message-ID: <871up946m8.fsf@dehydrator.spatula.rdu.redhat.com> (raw)
In-Reply-To: <1330812262-28272-1-git-send-email-tbielawa@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1377 bytes --]
On Sat, 3 Mar 2012 17:04:22 -0500, Tim Bielawa <tbielawa@redhat.com> wrote:
> The addition of mml-quote-region (notmuch-mua.el) in 2c6710e3 breaks
> automatic signing in replies. When replies are mml-quoted and signing
> is enabled by default the "<#part sign=pgpmime>" string will appear on
> line 1. This will be consumed during the application of the
> mml-quote-region function and transform into the inert string
> "<#!part sign=pgpmime>". The result is that responses will no longer
> be signed by default.
>
> This fix moves the point forward one line before applying the quoting
> function.
>
> Consideration: Clients not signing mail by default. The first line of
> their responses would be skipped when the quoting function is
> applied. This string takes this general form:
>
> On Sat, 03 Mar 2012 12:55:14 -0800, notmuch-request@notmuchmail.org wrote:
>
> Because the string is generated by notmuch I don't believe this fix
> introduces the possibility for malicious mml commands being omitted
> from the quoting.
I suppose I should add that when running the unit tests the relevant
parts still pass:
> PASS Reply within emacs
> PASS Quote MML tags in reply
--
Tim Bielawa, Software Engineer/Scribe
Production Control Team (RDU)
919.332.6411 Cell | IRC: tbielawa
1BA0 4FAB 4C13 FBA0 A036 4958 AD05 E75E 0333 AE37
[-- Attachment #2: Type: application/pgp-signature, Size: 162 bytes --]
next prev parent reply other threads:[~2012-03-03 23:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-03 22:04 [PATCH] Fix mml-quoting in responses where pgp-signing is enabled Tim Bielawa
2012-03-03 23:17 ` Tim Bielawa [this message]
2012-03-03 23:36 ` Jani Nikula
2012-03-04 1:12 ` Tim Bielawa
2012-03-04 8:25 ` [PATCH] emacs: fix MML quoting in replies Jani Nikula
2012-03-05 0:41 ` Mark Walters
2012-03-10 14:57 ` Tomi Ollila
2012-03-11 1:50 ` David Bremner
2012-03-14 22:08 ` Austin Clements
2012-03-15 6:33 ` Jani Nikula
-- strict thread matches above, loose matches on Subject: below --
2012-03-03 23:54 [PATCH] Fix mml-quoting in responses where pgp-signing is enabled Tim Bielawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871up946m8.fsf@dehydrator.spatula.rdu.redhat.com \
--to=tbielawa@redhat.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).