From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 62D14431FAF for ; Sat, 3 Mar 2012 15:17:29 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -4.99 X-Spam-Level: X-Spam-Status: No, score=-4.99 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_HI=-5, T_MIME_NO_TEXT=0.01] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rqSL2QTrAPYa for ; Sat, 3 Mar 2012 15:17:28 -0800 (PST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by olra.theworths.org (Postfix) with ESMTP id 9B618431FAE for ; Sat, 3 Mar 2012 15:17:28 -0800 (PST) Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q23NHR8T008136 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sat, 3 Mar 2012 18:17:27 -0500 Received: from dehydrator.rdu.redhat.com (spatula.rdu.redhat.com [10.11.95.223]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q23NHRuZ024813 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Sat, 3 Mar 2012 18:17:27 -0500 Received: from dehydrator.spatula.rdu.redhat.com (localhost [127.0.0.1]) by dehydrator.rdu.redhat.com (Postfix) with ESMTP id CB66D23347 for ; Sat, 3 Mar 2012 18:17:26 -0500 (EST) Received: (from tbielawa@localhost) by dehydrator.spatula.rdu.redhat.com (8.14.5/8.14.5/Submit) id q23NHQ9e011666; Sat, 3 Mar 2012 18:17:26 -0500 X-Authentication-Warning: dehydrator.spatula.rdu.redhat.com: tbielawa set sender to tbielawa@redhat.com using -f From: Tim Bielawa To: notmuch@notmuchmail.org Subject: Re: [PATCH] Fix mml-quoting in responses where pgp-signing is enabled In-Reply-To: <1330812262-28272-1-git-send-email-tbielawa@redhat.com> References: <1330812262-28272-1-git-send-email-tbielawa@redhat.com> User-Agent: Notmuch/0.12~rc1 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-redhat-linux-gnu) Date: Sat, 03 Mar 2012 18:17:19 -0500 Message-ID: <871up946m8.fsf@dehydrator.spatula.rdu.redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Mar 2012 23:17:29 -0000 --=-=-= Content-Transfer-Encoding: quoted-printable On Sat, 3 Mar 2012 17:04:22 -0500, Tim Bielawa wrote: > The addition of mml-quote-region (notmuch-mua.el) in 2c6710e3 breaks > automatic signing in replies. When replies are mml-quoted and signing > is enabled by default the "<#part sign=3Dpgpmime>" string will appear on > line 1. This will be consumed during the application of the > mml-quote-region function and transform into the inert string > "<#!part sign=3Dpgpmime>". The result is that responses will no longer > be signed by default. >=20 > This fix moves the point forward one line before applying the quoting > function. >=20 > Consideration: Clients not signing mail by default. The first line of > their responses would be skipped when the quoting function is > applied. This string takes this general form: >=20 > On Sat, 03 Mar 2012 12:55:14 -0800, notmuch-request@notmuchmail.org w= rote: >=20 > Because the string is generated by notmuch I don't believe this fix > introduces the possibility for malicious mml commands being omitted > from the quoting. I suppose I should add that when running the unit tests the relevant parts still pass: > PASS Reply within emacs > PASS Quote MML tags in reply =20 =2D-=20 Tim Bielawa, Software Engineer/Scribe Production Control Team (RDU) 919.332.6411 Cell | IRC: tbielawa 1BA0 4FAB 4C13 FBA0 A036 4958 AD05 E75E 0333 AE37 --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- iEYEARECAAYFAk9Spn8ACgkQrQXnXgMzrjclggCgtvnno2G9p4F2kIB1CzN3eQOk 680An2ms7A+53SDHXL0UGiPncJaYA9hU =cHbE -----END PGP SIGNATURE----- --=-=-=--