From: Mark Walters <markwalters1009@gmail.com>
To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
Subject: Re: [PATCH 07/14] test: Tests for future version and unknown feature handling
Date: Sun, 27 Jul 2014 09:51:14 +0100 [thread overview]
Message-ID: <871tt718xp.fsf@qmul.ac.uk> (raw)
In-Reply-To: <1406433173-19169-8-git-send-email-amdragon@mit.edu>
On Sun, 27 Jul 2014, Austin Clements <amdragon@MIT.EDU> wrote:
> ---
> test/T530-upgrade.sh | 46 ++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 46 insertions(+)
Hi
Just a quick comment on this patch so far. After this patch I got lots
of test failures in the second (old) part of T530-upgrade because I
hadn't downloaded the test databases: prior to this patch no tests
failed because those tests were skipped.
Once I downloaded the databases everything was fine again so the problem
is just that this patch is breaking the automatic skipping of the
old tests in T530-upgrade.
Best wishes
Mark
next prev parent reply other threads:[~2014-07-27 8:51 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-27 3:52 [PATCH 0/14] Implement and use database "features" Austin Clements
2014-07-27 3:52 ` [PATCH 01/14] test: Include generated dependencies for test sources Austin Clements
2014-07-27 3:52 ` [PATCH 02/14] util: Make string-util.h C++-compatible Austin Clements
2014-07-27 3:52 ` [PATCH 03/14] util: Const version of strtok_len Austin Clements
2014-07-27 3:52 ` [PATCH 04/14] new: Don't report version after upgrade Austin Clements
2014-07-27 9:33 ` Mark Walters
2014-07-27 16:24 ` Austin Clements
2014-07-27 3:52 ` [PATCH 05/14] lib: Database version 3: Introduce fine-grained "features" Austin Clements
2014-07-27 9:53 ` Mark Walters
2014-07-27 16:58 ` Austin Clements
2014-07-27 3:52 ` [PATCH 06/14] test: Tool to build DB with specific version and features Austin Clements
2014-07-27 3:52 ` [PATCH 07/14] test: Tests for future version and unknown feature handling Austin Clements
2014-07-27 8:51 ` Mark Walters [this message]
2014-07-27 16:12 ` Austin Clements
2014-07-27 3:52 ` [PATCH 08/14] lib: Simplify upgrade code using a transaction Austin Clements
2014-07-27 9:35 ` Mark Walters
2014-07-27 16:42 ` Austin Clements
2014-07-27 3:52 ` [PATCH 09/14] lib: Use database features to drive upgrade Austin Clements
2014-07-27 3:52 ` [PATCH 10/14] lib: Reorganize upgrade around document types Austin Clements
2014-07-27 3:52 ` [PATCH 11/14] lib: Report progress for combined upgrade operation Austin Clements
2014-07-27 3:52 ` [PATCH 12/14] lib: Support empty header values in database Austin Clements
2014-07-27 3:52 ` [PATCH 13/14] lib: Return an error from operations that require an upgrade Austin Clements
2014-07-27 3:52 ` [PATCH 14/14] lib: Update doc of notmuch_database_{needs_upgrade, upgrade} Austin Clements
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871tt718xp.fsf@qmul.ac.uk \
--to=markwalters1009@gmail.com \
--cc=amdragon@MIT.EDU \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).