unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Austin Clements <amdragon@MIT.EDU>
To: notmuch@notmuchmail.org
Subject: [PATCH 04/14] new: Don't report version after upgrade
Date: Sat, 26 Jul 2014 23:52:43 -0400	[thread overview]
Message-ID: <1406433173-19169-5-git-send-email-amdragon@mit.edu> (raw)
In-Reply-To: <1406433173-19169-1-git-send-email-amdragon@mit.edu>

The version number has always been pretty meaningless to the user and
it's about to become even more meaningless with the introduction of
"features".  Hopefully, the database will remain on version 3 for some
time to come; however, the introduction of new features over time in
version 3 will necessitate upgrades within version 3.  It would be
confusing if we always tell the user they've been "upgraded to version
3".  If the user wants to know what's new, they should read the news.
---
 notmuch-new.c        | 3 +--
 test/T530-upgrade.sh | 2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/notmuch-new.c b/notmuch-new.c
index d269c7c..b7590a8 100644
--- a/notmuch-new.c
+++ b/notmuch-new.c
@@ -1023,8 +1023,7 @@ notmuch_new_command (notmuch_config_t *config, int argc, char *argv[])
 				      add_files_state.verbosity >= VERBOSITY_NORMAL ? upgrade_print_progress : NULL,
 				      &add_files_state);
 	    if (add_files_state.verbosity >= VERBOSITY_NORMAL)
-		printf ("Your notmuch database has now been upgraded to database format version %u.\n",
-		    notmuch_database_get_version (notmuch));
+		printf ("Your notmuch database has now been upgraded.\n");
 	}
 
 	add_files_state.total_files = 0;
diff --git a/test/T530-upgrade.sh b/test/T530-upgrade.sh
index 7d5d5aa..c4c4ac8 100755
--- a/test/T530-upgrade.sh
+++ b/test/T530-upgrade.sh
@@ -33,7 +33,7 @@ test_expect_equal "$output" "\
 Welcome to a new version of notmuch! Your database will now be upgraded.
 This process is safe to interrupt.
 Backing up tags to FILENAME
-Your notmuch database has now been upgraded to database format version 2.
+Your notmuch database has now been upgraded.
 No new mail."
 
 test_begin_subtest "tag backup matches pre-upgrade dump"
-- 
2.0.0

  parent reply	other threads:[~2014-07-27  3:53 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-27  3:52 [PATCH 0/14] Implement and use database "features" Austin Clements
2014-07-27  3:52 ` [PATCH 01/14] test: Include generated dependencies for test sources Austin Clements
2014-07-27  3:52 ` [PATCH 02/14] util: Make string-util.h C++-compatible Austin Clements
2014-07-27  3:52 ` [PATCH 03/14] util: Const version of strtok_len Austin Clements
2014-07-27  3:52 ` Austin Clements [this message]
2014-07-27  9:33   ` [PATCH 04/14] new: Don't report version after upgrade Mark Walters
2014-07-27 16:24     ` Austin Clements
2014-07-27  3:52 ` [PATCH 05/14] lib: Database version 3: Introduce fine-grained "features" Austin Clements
2014-07-27  9:53   ` Mark Walters
2014-07-27 16:58     ` Austin Clements
2014-07-27  3:52 ` [PATCH 06/14] test: Tool to build DB with specific version and features Austin Clements
2014-07-27  3:52 ` [PATCH 07/14] test: Tests for future version and unknown feature handling Austin Clements
2014-07-27  8:51   ` Mark Walters
2014-07-27 16:12     ` Austin Clements
2014-07-27  3:52 ` [PATCH 08/14] lib: Simplify upgrade code using a transaction Austin Clements
2014-07-27  9:35   ` Mark Walters
2014-07-27 16:42     ` Austin Clements
2014-07-27  3:52 ` [PATCH 09/14] lib: Use database features to drive upgrade Austin Clements
2014-07-27  3:52 ` [PATCH 10/14] lib: Reorganize upgrade around document types Austin Clements
2014-07-27  3:52 ` [PATCH 11/14] lib: Report progress for combined upgrade operation Austin Clements
2014-07-27  3:52 ` [PATCH 12/14] lib: Support empty header values in database Austin Clements
2014-07-27  3:52 ` [PATCH 13/14] lib: Return an error from operations that require an upgrade Austin Clements
2014-07-27  3:52 ` [PATCH 14/14] lib: Update doc of notmuch_database_{needs_upgrade, upgrade} Austin Clements

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1406433173-19169-5-git-send-email-amdragon@mit.edu \
    --to=amdragon@mit.edu \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).