From: Austin Clements <amdragon@MIT.EDU>
To: Mark Walters <markwalters1009@gmail.com>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH 04/14] new: Don't report version after upgrade
Date: Sun, 27 Jul 2014 12:24:26 -0400 [thread overview]
Message-ID: <20140727162426.GF13893@mit.edu> (raw)
In-Reply-To: <87y4vfywmp.fsf@qmul.ac.uk>
Quoth Mark Walters on Jul 27 at 10:33 am:
> On Sun, 27 Jul 2014, Austin Clements <amdragon@MIT.EDU> wrote:
> > The version number has always been pretty meaningless to the user and
> > it's about to become even more meaningless with the introduction of
> > "features". Hopefully, the database will remain on version 3 for some
> > time to come; however, the introduction of new features over time in
> > version 3 will necessitate upgrades within version 3. It would be
> > confusing if we always tell the user they've been "upgraded to version
> > 3". If the user wants to know what's new, they should read the news.
>
> Two thoughts on this:
>
> first, we could print the names of the new features here to make it
> easier for the user to find them in NEWS.
Interesting. Transparency is good, though I worry that this would
expose the user to internal implementation details (certainly some
features will translate to user-visible features, but others will be
entirely internal to the library).
> Secondly, would it be worth having something like notmuch
> --database-version or similar which prints the features? If I understand
> the series then notmuch clients don't necessarily need to upgrade the
> database unless they want the new features. This means that knowing what
> version they are running might not tell us which features they have
> enabled (which could make debugging difficult)
Good idea, though I'd be inclined to do it in a follow-up series just
so this series doesn't get even longer. It won't be a problem for
now: this series doesn't touch our current policy of unconditionally
upgrading on notmuch new (a policy I think we should keep, though
that's a separate discussion) so the notmuch version should still tell
us the database version/features.
> Best wishes
>
> Mark
>
> > ---
> > notmuch-new.c | 3 +--
> > test/T530-upgrade.sh | 2 +-
> > 2 files changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/notmuch-new.c b/notmuch-new.c
> > index d269c7c..b7590a8 100644
> > --- a/notmuch-new.c
> > +++ b/notmuch-new.c
> > @@ -1023,8 +1023,7 @@ notmuch_new_command (notmuch_config_t *config, int argc, char *argv[])
> > add_files_state.verbosity >= VERBOSITY_NORMAL ? upgrade_print_progress : NULL,
> > &add_files_state);
> > if (add_files_state.verbosity >= VERBOSITY_NORMAL)
> > - printf ("Your notmuch database has now been upgraded to database format version %u.\n",
> > - notmuch_database_get_version (notmuch));
> > + printf ("Your notmuch database has now been upgraded.\n");
> > }
> >
> > add_files_state.total_files = 0;
> > diff --git a/test/T530-upgrade.sh b/test/T530-upgrade.sh
> > index 7d5d5aa..c4c4ac8 100755
> > --- a/test/T530-upgrade.sh
> > +++ b/test/T530-upgrade.sh
> > @@ -33,7 +33,7 @@ test_expect_equal "$output" "\
> > Welcome to a new version of notmuch! Your database will now be upgraded.
> > This process is safe to interrupt.
> > Backing up tags to FILENAME
> > -Your notmuch database has now been upgraded to database format version 2.
> > +Your notmuch database has now been upgraded.
> > No new mail."
> >
> > test_begin_subtest "tag backup matches pre-upgrade dump"
next prev parent reply other threads:[~2014-07-27 16:24 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-27 3:52 [PATCH 0/14] Implement and use database "features" Austin Clements
2014-07-27 3:52 ` [PATCH 01/14] test: Include generated dependencies for test sources Austin Clements
2014-07-27 3:52 ` [PATCH 02/14] util: Make string-util.h C++-compatible Austin Clements
2014-07-27 3:52 ` [PATCH 03/14] util: Const version of strtok_len Austin Clements
2014-07-27 3:52 ` [PATCH 04/14] new: Don't report version after upgrade Austin Clements
2014-07-27 9:33 ` Mark Walters
2014-07-27 16:24 ` Austin Clements [this message]
2014-07-27 3:52 ` [PATCH 05/14] lib: Database version 3: Introduce fine-grained "features" Austin Clements
2014-07-27 9:53 ` Mark Walters
2014-07-27 16:58 ` Austin Clements
2014-07-27 3:52 ` [PATCH 06/14] test: Tool to build DB with specific version and features Austin Clements
2014-07-27 3:52 ` [PATCH 07/14] test: Tests for future version and unknown feature handling Austin Clements
2014-07-27 8:51 ` Mark Walters
2014-07-27 16:12 ` Austin Clements
2014-07-27 3:52 ` [PATCH 08/14] lib: Simplify upgrade code using a transaction Austin Clements
2014-07-27 9:35 ` Mark Walters
2014-07-27 16:42 ` Austin Clements
2014-07-27 3:52 ` [PATCH 09/14] lib: Use database features to drive upgrade Austin Clements
2014-07-27 3:52 ` [PATCH 10/14] lib: Reorganize upgrade around document types Austin Clements
2014-07-27 3:52 ` [PATCH 11/14] lib: Report progress for combined upgrade operation Austin Clements
2014-07-27 3:52 ` [PATCH 12/14] lib: Support empty header values in database Austin Clements
2014-07-27 3:52 ` [PATCH 13/14] lib: Return an error from operations that require an upgrade Austin Clements
2014-07-27 3:52 ` [PATCH 14/14] lib: Update doc of notmuch_database_{needs_upgrade, upgrade} Austin Clements
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140727162426.GF13893@mit.edu \
--to=amdragon@mit.edu \
--cc=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).