* [PATCH] vim: Patch Ruby Mail's depracated method
@ 2019-03-18 14:10 Tarvi Verro
2019-06-25 20:36 ` Daniel Kahn Gillmor
0 siblings, 1 reply; 2+ messages in thread
From: Tarvi Verro @ 2019-03-18 14:10 UTC (permalink / raw)
To: notmuch; +Cc: Tarvi Verro
Method is not supported in Ruby's Mail 2.8.0+.
---
vim/notmuch.vim | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/vim/notmuch.vim b/vim/notmuch.vim
index ad8b7c80..541698cd 100644
--- a/vim/notmuch.vim
+++ b/vim/notmuch.vim
@@ -666,7 +666,7 @@ ruby << EOF
date = Time.at(e.newest_date).strftime(date_fmt)
subject = e.messages.first['subject']
if $mail_installed
- subject = Mail::Field.new("Subject: " + subject).to_s
+ subject = Mail::Field.parse("Subject: " + subject).to_s
else
subject = subject.force_encoding('utf-8')
end
--
2.21.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] vim: Patch Ruby Mail's depracated method
2019-03-18 14:10 [PATCH] vim: Patch Ruby Mail's depracated method Tarvi Verro
@ 2019-06-25 20:36 ` Daniel Kahn Gillmor
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Kahn Gillmor @ 2019-06-25 20:36 UTC (permalink / raw)
To: Tarvi Verro, notmuch
[-- Attachment #1: Type: text/plain, Size: 1223 bytes --]
On Mon 2019-03-18 15:10:51 +0100, Tarvi Verro wrote:
> Method is not supported in Ruby's Mail 2.8.0+.
> ---
> vim/notmuch.vim | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/vim/notmuch.vim b/vim/notmuch.vim
> index ad8b7c80..541698cd 100644
> --- a/vim/notmuch.vim
> +++ b/vim/notmuch.vim
> @@ -666,7 +666,7 @@ ruby << EOF
> date = Time.at(e.newest_date).strftime(date_fmt)
> subject = e.messages.first['subject']
> if $mail_installed
> - subject = Mail::Field.new("Subject: " + subject).to_s
> + subject = Mail::Field.parse("Subject: " + subject).to_s
> else
> subject = subject.force_encoding('utf-8')
> end
> --
I see this patch is marked "notmuch::moreinfo", but i don't see any
request for more info specifically, so i thought i'd fill that in here.
I don't know vim or ruby, but i would expect a patch like this to
contain at least a pointer to Ruby's Mail package's documentation about
a backward-incompatible change introduced in a certain version, if not
documentation about the expected upgrade path. Can you provide those
pointers?
Thanks for offering fixes to the notmuch-vim codebase!
--dkg
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-25 22:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-18 14:10 [PATCH] vim: Patch Ruby Mail's depracated method Tarvi Verro
2019-06-25 20:36 ` Daniel Kahn Gillmor
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).