From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id C62B86DE0F76 for ; Tue, 25 Jun 2019 15:47:19 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.567 X-Spam-Level: X-Spam-Status: No, score=-0.567 tagged_above=-999 required=5 tests=[AWL=0.334, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id a22VbQPmWFnj for ; Tue, 25 Jun 2019 15:47:18 -0700 (PDT) Received: from che.mayfirst.org (che.mayfirst.org [162.247.75.118]) by arlo.cworth.org (Postfix) with ESMTPS id 40D9C6DE0F54 for ; Tue, 25 Jun 2019 15:47:17 -0700 (PDT) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/simple; d=fifthhorseman.net; i=@fifthhorseman.net; q=dns/txt; s=2019; t=1561502835; h=from : to : subject : in-reply-to : references : date : message-id : mime-version : content-type : from; bh=Q/NTtxDO+P7TkC0zK8ZLZUzz4NufpAJGNG31pMq2Ukg=; b=r/oaVYKJzoq1zPusuliRHF37CL0+VXmvRgs+a8JgVQluy5wMGjE5TEcG jdwyP1VSCFykk5TjmTGJMTgWC8f6AQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fifthhorseman.net; i=@fifthhorseman.net; q=dns/txt; s=2019rsa; t=1561502835; h=from : to : subject : in-reply-to : references : date : message-id : mime-version : content-type : from; bh=Q/NTtxDO+P7TkC0zK8ZLZUzz4NufpAJGNG31pMq2Ukg=; b=ppLFCVdujCAJa3BCh8FQLiV/bu4q0z41zp56RL2hDAm5x6p6C0kz1pZA XolSpdpkngs/HvX2ZxvjNV1g99dLjndO5IENxvprXUo9X+xwJMXvFAs5CA tBIcA6JPlty4s/vdb1qjfzqRqSfeL+VICDQ9260YW8l/iT1yz5vB8X0h0s 4v0k6DcvFyaKKq/VoGmgkgpJAc4oLzFjsFOQWeAwZlkiLWRY2LFpmcL70T LVAxnW3lPW2FLM/E0A9eW0i3BbpOB9b01uPL9T3PRa38iONQplO4JmvPoN fmAHXzAM7A8Pum+OXI+rkrYemIMUk81sevBPgcjGzXpnV0mDSyZdsg== Received: from fifthhorseman.net (unknown [38.109.115.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by che.mayfirst.org (Postfix) with ESMTPSA id B877FF99D; Tue, 25 Jun 2019 18:47:15 -0400 (EDT) Received: by fifthhorseman.net (Postfix, from userid 1000) id 097FC20257; Tue, 25 Jun 2019 16:36:56 -0400 (EDT) From: Daniel Kahn Gillmor To: Tarvi Verro , notmuch@notmuchmail.org Subject: Re: [PATCH] vim: Patch Ruby Mail's depracated method In-Reply-To: <20190318141051.9355-1-tarvi.verro@gmail.com> References: <20190318141051.9355-1-tarvi.verro@gmail.com> Autocrypt: addr=dkg@fifthhorseman.net; prefer-encrypt=mutual; keydata= mDMEXEK/AhYJKwYBBAHaRw8BAQdAr/gSROcn+6m8ijTN0DV9AahoHGafy52RRkhCZVwxhEe0K0Rh bmllbCBLYWhuIEdpbGxtb3IgPGRrZ0BmaWZ0aGhvcnNlbWFuLm5ldD6ImQQTFggAQQIbAQUJA8Jn AAULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBMS8Lds4zOlkhevpwvIGkReQOOXGBQJcQsbzAhkB AAoJEPIGkReQOOXG4fkBAO1joRxqAZY57PjdzGieXLpluk9RkWa3ufkt3YUVEpH/AP9c+pgIxtyW +FwMQRjlqljuj8amdN4zuEqaCy4hhz/1DbgzBFxCv4sWCSsGAQQB2kcPAQEHQERSZxSPmgtdw6nN u7uxY7bzb9TnPrGAOp9kClBLRwGfiPUEGBYIACYWIQTEvC3bOMzpZIXr6cLyBpEXkDjlxgUCXEK/ iwIbAgUJAeEzgACBCRDyBpEXkDjlxnYgBBkWCAAdFiEEyQ5tNiAKG5IqFQnndhgZZSmuX/gFAlxC v4sACgkQdhgZZSmuX/iVWgD/fCU4ONzgy8w8UCHGmrmIZfDvdhg512NIBfx+Mz9ls5kA/Rq97vz4 z48MFuBdCuu0W/fVqVjnY7LN5n+CQJwGC0MIA7QA/RyY7Sz2gFIOcrns0RpoHr+3WI+won3xCD8+ sVXSHZvCAP98HCjDnw/b0lGuCR7coTXKLIM44/LFWgXAdZjm1wjODbg4BFxCv50SCisGAQQBl1UB BQEBB0BG4iXnHX/fs35NWKMWQTQoRI7oiAUt0wJHFFJbomxXbAMBCAeIfgQYFggAJhYhBMS8Lds4 zOlkhevpwvIGkReQOOXGBQJcQr+dAhsMBQkB4TOAAAoJEPIGkReQOOXGe/cBAPlek5d9xzcXUn/D kY6jKmxe26CTws3ZkbK6Aa5Ey/qKAP0VuPQSCRxA7RKfcB/XrEphfUFkraL06Xn/xGwJ+D0hCw== Date: Tue, 25 Jun 2019 16:36:55 -0400 Message-ID: <877e99v1ug.fsf@fifthhorseman.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Jun 2019 22:47:19 -0000 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Mon 2019-03-18 15:10:51 +0100, Tarvi Verro wrote: > Method is not supported in Ruby's Mail 2.8.0+. > --- > vim/notmuch.vim | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/vim/notmuch.vim b/vim/notmuch.vim > index ad8b7c80..541698cd 100644 > --- a/vim/notmuch.vim > +++ b/vim/notmuch.vim > @@ -666,7 +666,7 @@ ruby << EOF > date =3D Time.at(e.newest_date).strftime(date_fmt) > subject =3D e.messages.first['subject'] > if $mail_installed > - subject =3D Mail::Field.new("Subject: " + subject).to_s > + subject =3D Mail::Field.parse("Subject: " + subject).to_s > else > subject =3D subject.force_encoding('utf-8') > end > --=20 I see this patch is marked "notmuch::moreinfo", but i don't see any request for more info specifically, so i thought i'd fill that in here. I don't know vim or ruby, but i would expect a patch like this to contain at least a pointer to Ruby's Mail package's documentation about a backward-incompatible change introduced in a certain version, if not documentation about the expected upgrade path. Can you provide those pointers? Thanks for offering fixes to the notmuch-vim codebase! --dkg --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQTJDm02IAobkioVCed2GBllKa5f+AUCXRKF5wAKCRB2GBllKa5f +NlSAP9eF8UbPmTdbRf4vC1JhaJXNfFOewrsj3bnJlEtXUj44gEAxjGQlcf8AtQ4 dVGgdOInjE2yd98T425V6Lehgn5VRQU= =kk85 -----END PGP SIGNATURE----- --=-=-=--