unread flag and maildir syncing

unread flag and maildir syncing

[David Bremner]

1/2 is just a fixup for a typo that I made (and Tomi missed ;))
2/2 is to help decide the desired behaviour without 'unread' in new.tags

The current behaviour is that maildir flags win:

| unread in new.tags | ,S on file name | unread tag in db |
| Y                  | Y               | N                |
| N                  | Y               | N                |
| Y                  | N               | Y                |
| N                  | N               | Y                |

This means in particular that files in new/ have unread whether or not
the user specifies that in new.tags.  That might be the right
behaviour (it's certainly easier to impliment). I just want to confirm
either way before I update notmuch-new (and potentially drop the
"unread is not mandatory in new" test)

d

[PATCH 1/2] test: add missing quotes in maildir-sync test.

[David Bremner]

Oops. ';' is significant in the shell. Who knew.
---
 test/T340-maildir-sync.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/T340-maildir-sync.sh b/test/T340-maildir-sync.sh
index 8024d86f..2041e1a0 100755
--- a/test/T340-maildir-sync.sh
+++ b/test/T340-maildir-sync.sh
@@ -181,7 +181,7 @@ test_expect_equal "$(cd $MAIL_DIR/cur/; ls non-compliant*)" "non-compliant-maild
 
 test_begin_subtest "Files in new/ get default synchronized tags"
 OLDCONFIG=$(notmuch config get new.tags)
-notmuch config set new.tags test;unread
+notmuch config set new.tags "test;unread"
 add_message [subject]='"File in new/"' [dir]=new [filename]='file-in-new'
 notmuch config set new.tags $OLDCONFIG
 notmuch search 'subject:"File in new"' | notmuch_search_sanitize > output
-- 
2.13.2

[PATCH 2/2] test: add test for , S message without 'unread' in new.tags

[David Bremner]

This is arguably overkill, but it helps to understand the complicated
interactions here between maildir tags and configuration.
---
 test/T340-maildir-sync.sh | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/test/T340-maildir-sync.sh b/test/T340-maildir-sync.sh
index 2041e1a0..433effef 100755
--- a/test/T340-maildir-sync.sh
+++ b/test/T340-maildir-sync.sh
@@ -28,6 +28,14 @@ add_message [subject]='"Adding message with S"' [filename]='adding-with-s-flag:2
 output=$(notmuch search subject:"Adding message with S" | notmuch_search_sanitize)
 test_expect_equal "$output" "thread:XXX   2001-01-05 [1/1] Notmuch Test Suite; Adding message with S (inbox)"
 
+test_begin_subtest "Adding message with 'S' w/o 'unread' in new.tags prevents 'unread' tag"
+OLDCONFIG=$(notmuch config get new.tags)
+notmuch config set new.tags "inbox"
+add_message [subject]='"Adding message with S 2"' [filename]='adding-with-s-flag2:2,S' [dir]=cur
+notmuch config set new.tags $OLDCONFIG
+output=$(notmuch search subject:Adding-message-with-S-2 | notmuch_search_sanitize)
+test_expect_equal "$output" "thread:XXX   2001-01-05 [1/1] Notmuch Test Suite; Adding message with S 2 (inbox)"
+
 test_begin_subtest "Adding 'replied' tag adds 'R' flag to filename"
 add_message [subject]='"Adding replied tag"' [filename]='adding-replied-tag:2,S' [dir]=cur
 notmuch tag +replied subject:"Adding replied tag"
@@ -49,7 +57,7 @@ test_expect_equal_json "$output" '[[[{"id": "XXXXX",
 "Date": "GENERATED_DATE"},
 "body": [{"id": 1,
 "content-type": "text/plain",
-"content": "This is just a test message (#3)\n"}]},
+"content": "This is just a test message (#4)\n"}]},
 []]]]'
 
 test_begin_subtest "notmuch reply works with renamed file (without notmuch new)"
-- 
2.13.2

Re: unread flag and maildir syncing

[Tomi Ollila]

On Tue, Aug 08 2017, David Bremner wrote:

> 1/2 is just a fixup for a typo that I made (and Tomi missed ;))

my scripts have 'set -euf' in the beginning, so I am not used to see such a
broken constructs (don't do yourself what computer can do for you ;)

Tomi

>
> d

Re: unread flag and maildir syncing

[David Bremner]

David Bremner <david@tethera.net> writes:

> 1/2 is just a fixup for a typo that I made (and Tomi missed ;))
> 2/2 is to help decide the desired behaviour without 'unread' in new.tags
>
> The current behaviour is that maildir flags win:
>
> | unread in new.tags | ,S on file name | unread tag in db |
> | Y                  | Y               | N                |
> | N                  | Y               | N                |
> | Y                  | N               | Y                |
> | N                  | N               | Y                |
>
> This means in particular that files in new/ have unread whether or not
> the user specifies that in new.tags.  That might be the right
> behaviour (it's certainly easier to impliment). I just want to confirm
> either way before I update notmuch-new (and potentially drop the
> "unread is not mandatory in new" test)

Series pushed to master. Fix is still in progress.

d