unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: "Kevin J. McCarthy" <kevin@8t8.us>
To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
Cc: Stefano Zacchiroli <zack@upsilon.cc>
Subject: Re: [PATCH 1/1] notmuch-mutt: Fix tagging issues
Date: Sat, 7 Sep 2013 08:57:48 -0700	[thread overview]
Message-ID: <20130907155748.GD4226@zaogao.lan> (raw)
In-Reply-To: <m2mwnprq7o.fsf@guru.guru-group.fi>

[-- Attachment #1: Type: text/plain, Size: 636 bytes --]

Tomi Ollila wrote:
> The patch looks good to me, just that I cannot test it. +1.
> 
> If it weren't inconsistent what is there now a simpler alternative could be:
> 
> system qw/notmuch tag/, @_, '--', "id:$mid";
> 
> or even
> 
> exec qw/notmuch tag/, @_, '--', "id:$mid";
> 
> ... as these bypasses the intermediate shell altogether.

Thank you for the great suggestion.  I completely forgot about the list
form of system while focusing on the patch :-).  Since we don't need the
shell in this case, it makes sense to use that form.

Please hold off on committing this patch.  I will post a revised patch.

-Kevin

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]

  reply	other threads:[~2013-09-07 15:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-06 22:15 [PATCH 1/1] notmuch-mutt: Fix tagging issues Kevin J. McCarthy
2013-09-07  8:27 ` Tomi Ollila
2013-09-07 15:57   ` Kevin J. McCarthy [this message]
2013-09-07 17:07     ` [PATCH v2 " Kevin J. McCarthy
2013-09-08 15:50       ` Tomi Ollila
2013-09-09  1:52       ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130907155748.GD4226@zaogao.lan \
    --to=kevin@8t8.us \
    --cc=notmuch@notmuchmail.org \
    --cc=tomi.ollila@iki.fi \
    --cc=zack@upsilon.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).