From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 64FF0431FAE for ; Sat, 7 Sep 2013 08:58:08 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.799 X-Spam-Level: X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1G5H7vODPFfx for ; Sat, 7 Sep 2013 08:58:04 -0700 (PDT) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 0F256431FAF for ; Sat, 7 Sep 2013 08:58:04 -0700 (PDT) Received: from compute1.internal (compute1.nyi.mail.srv.osa [10.202.2.41]) by gateway1.nyi.mail.srv.osa (Postfix) with ESMTP id 3BABA20A92; Sat, 7 Sep 2013 11:57:51 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Sat, 07 Sep 2013 11:57:51 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=8t8.us; h=date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=g5pVOj5G5lNpUisjeUarP1IW tBs=; b=mbEVUD3WWQtfPP/uwLWrj/Jn21fh94Y6JjVuPUi8cIXogOyF+5zn26Lb MFAUR60zt4dwmG+2kwQa1OaawWGK40W1AMJYRaF3XsIRIou7hsuOO1dwYlGDMsRC HxBEOHaYacd9tQGGSY7IOXvTp7GB6ZWO/Ux82p9VRjfr01m3sWA= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:in-reply-to; s=smtpout; bh=g5pVOj5G5lNpUisjeUarP1IWtBs=; b=K9sIr7ouw2axrCrnY23HizMkzu4L EgDfthjKVCk/QwpQdahYsQ8yytFTlyML532i0JMttUc7fe00ERg4aboiufCxID/5 j0OyJsL+IqZJ8K/rUgdKbrJd+K9jWbg6wooTmNVrPZhjhTa9rZWmSX7RREEkntQ8 WnqGQtfWLMIoxsw= X-Sasl-enc: BelE2h3Mo2DwAovI4VYhZygjMOmt/YVPZWRW3PYzweVB 1378569470 Received: from localhost (unknown [97.125.94.9]) by mail.messagingengine.com (Postfix) with ESMTPA id 927C7C00E83; Sat, 7 Sep 2013 11:57:50 -0400 (EDT) Date: Sat, 7 Sep 2013 08:57:48 -0700 From: "Kevin J. McCarthy" To: Tomi Ollila , notmuch@notmuchmail.org Subject: Re: [PATCH 1/1] notmuch-mutt: Fix tagging issues Message-ID: <20130907155748.GD4226@zaogao.lan> Mail-Followup-To: Tomi Ollila , notmuch@notmuchmail.org, Stefano Zacchiroli References: <20130906221520.GC4226@zaogao.lan> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="47eKBCiAZYFK5l32" Content-Disposition: inline In-Reply-To: OpenPGP: id=B6B1CD9613699FB8; url=http://www.8t8.us/configs/13699FB8.asc.pubkey; preference=sign User-Agent: Mutt/1.5.21 (2010-09-15) Cc: Stefano Zacchiroli X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Sep 2013 15:58:08 -0000 --47eKBCiAZYFK5l32 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Tomi Ollila wrote: > The patch looks good to me, just that I cannot test it. +1. >=20 > If it weren't inconsistent what is there now a simpler alternative could = be: >=20 > system qw/notmuch tag/, @_, '--', "id:$mid"; >=20 > or even >=20 > exec qw/notmuch tag/, @_, '--', "id:$mid"; >=20 > ... as these bypasses the intermediate shell altogether. Thank you for the great suggestion. I completely forgot about the list form of system while focusing on the patch :-). Since we don't need the shell in this case, it makes sense to use that form. Please hold off on committing this patch. I will post a revised patch. -Kevin --47eKBCiAZYFK5l32 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) iQEcBAEBCAAGBQJSK0z8AAoJELaxzZYTaZ+46xMIALGkNa3DNeIFSziK5BDDFcEi /AOy0ldsXG0XX4B8ULCl/iOx2O4z4UHqvJ4PH1LvM9UlTOKOBwHSOnYBK370uHD1 gTwkuAvbMB+b3upW7E/9zagxhOlWjdSK/QVIeBWIQskRLJpavacwE+jg0yYDft9u CHXc/6DB+FP2O/3YGGB/mu7ynZTzSpzg2qViVDAJzz0dSjUVshquV35Z/WrKH4Pr W9CAMSZ9EGtiEZpL+KUCHyZvgqE606L/9LLOyNA1sZqcDHBMqQ6oLdbkOstm5JTn NubxmZY9pudkhuzv4Dx+Ye7tbCyimsTWb94vdksCCFD8IE5TJPmWUSNWP44/tCc= =9onv -----END PGP SIGNATURE----- --47eKBCiAZYFK5l32--