From: Justus Winter <4winter@informatik.uni-hamburg.de>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: RFC: Annotate internal_error with the attribute noreturn 2nd patchset
Date: Mon, 24 Sep 2012 14:50:50 +0200 [thread overview]
Message-ID: <20120924125050.13910.66110@thinkbox.jade-hamburg.de> (raw)
In-Reply-To: <873927hf9n.fsf@zancas.localnet>
Quoting David Bremner (2012-09-24 12:44:04)
> Justus Winter <4winter@informatik.uni-hamburg.de> writes:
>
> > We need to discuss where those kind of macro definitions abstracting
> > away compiler differences should go. None of the files in util
> > includes notmuch-private.h, so I was unsure whether it's okay to put
> > them there.
>
> How about a new header file in util/
>
> function-attributes.h or something like that?
>
> The util stuff is "lower level" than lib/ so it makes sense to me to put
> common stuff there.
Maybe we should add this file to compat?
Justus
next prev parent reply other threads:[~2012-09-24 12:50 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-21 12:50 [PATCH 1/2] Annotate internal_error with the attribute noreturn Justus Winter
2012-09-21 12:50 ` [PATCH 2/2] Avoid potentially dereferencing a NULL pointer Justus Winter
2012-09-22 16:19 ` Austin Clements
2012-09-24 12:55 ` Justus Winter
2012-09-21 20:31 ` [PATCH 1/2] Annotate internal_error with the attribute noreturn David Bremner
2012-09-22 16:12 ` Austin Clements
2012-09-22 20:03 ` Tomi Ollila
2012-09-24 10:31 ` RFC: Annotate internal_error with the attribute noreturn 2nd patchset Justus Winter
2012-09-24 10:31 ` [PATCH 1/5] RFC: Provide a __has_attribute compatibility macro Justus Winter
2012-09-24 10:31 ` [PATCH 2/5] RFC: Provide a NORETURN_ATTRIBUTE macro similar to PRINTF_ATTRIBUTE Justus Winter
2012-09-24 10:31 ` [PATCH 3/5] Fix the COERCE_STATUS macro Justus Winter
2012-09-24 10:31 ` [PATCH 4/5] Annotate internal_error with the attribute noreturn Justus Winter
2012-09-24 10:31 ` [PATCH 5/5] Avoid potentially dereferencing a NULL pointer Justus Winter
2012-09-24 10:44 ` RFC: Annotate internal_error with the attribute noreturn 2nd patchset David Bremner
2012-09-24 12:50 ` Justus Winter [this message]
2012-09-24 14:41 ` David Bremner
2012-09-24 15:21 ` [PATCH 1/6] Provide a __has_attribute compatibility macro Justus Winter
2012-09-24 15:21 ` [PATCH 2/6] Provide a NORETURN_ATTRIBUTE macro similar to PRINTF_ATTRIBUTE Justus Winter
2012-09-24 15:21 ` [PATCH 3/6] Extend compat/README Justus Winter
2012-09-24 15:21 ` [PATCH 4/6] Fix the COERCE_STATUS macro Justus Winter
2012-09-24 17:44 ` Austin Clements
2012-09-25 8:55 ` Tomi Ollila
2012-09-24 15:21 ` [PATCH 5/6] Annotate internal_error with the attribute noreturn Justus Winter
2012-09-24 15:21 ` [PATCH 6/6] Avoid potentially dereferencing a NULL pointer Justus Winter
2012-09-27 15:57 ` [PATCH 1/6] Provide a __has_attribute compatibility macro David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120924125050.13910.66110@thinkbox.jade-hamburg.de \
--to=4winter@informatik.uni-hamburg.de \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).