From: Austin Clements <amdragon@MIT.EDU>
To: Justus Winter <4winter@informatik.uni-hamburg.de>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH 2/2] Avoid potentially dereferencing a NULL pointer
Date: Sat, 22 Sep 2012 12:19:08 -0400 [thread overview]
Message-ID: <20120922161908.GF26662@mit.edu> (raw)
In-Reply-To: <1348231837-21700-2-git-send-email-4winter@informatik.uni-hamburg.de>
Quoth Justus Winter on Sep 21 at 2:50 pm:
> GMIME_IS_MULTIPART and GMIME_IS_MESSAGE both handle NULL pointers
> gracefully, but the G_OBJECT_TYPE used in the error handling block
> dereferences it without checking it first.
>
> Fix this by checking whether parent->part is valid.
>
> Found using the clang static analyzer.
Neat.
Can this actually happen, though? If so, I think this point is too
late to be checking for a NULL part field. It should probably be
checked when the mime_node_t is created so that mime_node_t never has
a NULL part field.
> Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
> ---
> mime-node.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mime-node.c b/mime-node.c
> index 97e8b48..839737a 100644
> --- a/mime-node.c
> +++ b/mime-node.c
> @@ -291,7 +291,7 @@ mime_node_child (mime_node_t *parent, int child)
> GMimeObject *sub;
> mime_node_t *node;
>
> - if (!parent || child < 0 || child >= parent->nchildren)
> + if (!parent || !parent->part || child < 0 || child >= parent->nchildren)
> return NULL;
>
> if (GMIME_IS_MULTIPART (parent->part)) {
next prev parent reply other threads:[~2012-09-22 16:19 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-21 12:50 [PATCH 1/2] Annotate internal_error with the attribute noreturn Justus Winter
2012-09-21 12:50 ` [PATCH 2/2] Avoid potentially dereferencing a NULL pointer Justus Winter
2012-09-22 16:19 ` Austin Clements [this message]
2012-09-24 12:55 ` Justus Winter
2012-09-21 20:31 ` [PATCH 1/2] Annotate internal_error with the attribute noreturn David Bremner
2012-09-22 16:12 ` Austin Clements
2012-09-22 20:03 ` Tomi Ollila
2012-09-24 10:31 ` RFC: Annotate internal_error with the attribute noreturn 2nd patchset Justus Winter
2012-09-24 10:31 ` [PATCH 1/5] RFC: Provide a __has_attribute compatibility macro Justus Winter
2012-09-24 10:31 ` [PATCH 2/5] RFC: Provide a NORETURN_ATTRIBUTE macro similar to PRINTF_ATTRIBUTE Justus Winter
2012-09-24 10:31 ` [PATCH 3/5] Fix the COERCE_STATUS macro Justus Winter
2012-09-24 10:31 ` [PATCH 4/5] Annotate internal_error with the attribute noreturn Justus Winter
2012-09-24 10:31 ` [PATCH 5/5] Avoid potentially dereferencing a NULL pointer Justus Winter
2012-09-24 10:44 ` RFC: Annotate internal_error with the attribute noreturn 2nd patchset David Bremner
2012-09-24 12:50 ` Justus Winter
2012-09-24 14:41 ` David Bremner
2012-09-24 15:21 ` [PATCH 1/6] Provide a __has_attribute compatibility macro Justus Winter
2012-09-24 15:21 ` [PATCH 2/6] Provide a NORETURN_ATTRIBUTE macro similar to PRINTF_ATTRIBUTE Justus Winter
2012-09-24 15:21 ` [PATCH 3/6] Extend compat/README Justus Winter
2012-09-24 15:21 ` [PATCH 4/6] Fix the COERCE_STATUS macro Justus Winter
2012-09-24 17:44 ` Austin Clements
2012-09-25 8:55 ` Tomi Ollila
2012-09-24 15:21 ` [PATCH 5/6] Annotate internal_error with the attribute noreturn Justus Winter
2012-09-24 15:21 ` [PATCH 6/6] Avoid potentially dereferencing a NULL pointer Justus Winter
2012-09-27 15:57 ` [PATCH 1/6] Provide a __has_attribute compatibility macro David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120922161908.GF26662@mit.edu \
--to=amdragon@mit.edu \
--cc=4winter@informatik.uni-hamburg.de \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).