From: Austin Clements <amdragon@MIT.EDU>
To: Justus Winter <4winter@informatik.uni-hamburg.de>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH 1/2] Annotate internal_error with the attribute noreturn
Date: Sat, 22 Sep 2012 12:12:56 -0400 [thread overview]
Message-ID: <20120922161256.GE26662@mit.edu> (raw)
In-Reply-To: <1348231837-21700-1-git-send-email-4winter@informatik.uni-hamburg.de>
LGTM, though I agree with David that this should return void now, if
that's possible.
Do we want to wrap the __attribute__((noreturn)) in an #ifdef __GNUC__
(or provide a PRINTF_ATTRIBUTE-like macro) or is that already a lost
cause?
Quoth Justus Winter on Sep 21 at 2:50 pm:
> Annotating functions that do not return with the noreturn attribute
> (which is understood by both gcc and clang) prevents static analyzers
> from generating false positives (internal_error is used to terminate
> the process and is used extensively in error handling code paths).
>
> Remove the return statement that was placed there to appease the
> compiler. Functions annotated with noreturn are not supposed to return
> any values.
>
> Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
> ---
> util/error_util.c | 2 --
> util/error_util.h | 2 +-
> 2 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/util/error_util.c b/util/error_util.c
> index 630d228..3cf353a 100644
> --- a/util/error_util.c
> +++ b/util/error_util.c
> @@ -35,7 +35,5 @@ _internal_error (const char *format, ...)
> vfprintf (stderr, format, va_args);
>
> exit (1);
> -
> - return 1;
> }
>
> diff --git a/util/error_util.h b/util/error_util.h
> index bb15822..24a644b 100644
> --- a/util/error_util.h
> +++ b/util/error_util.h
> @@ -30,7 +30,7 @@
> * Note that PRINTF_ATTRIBUTE comes from talloc.h
> */
> int
> -_internal_error (const char *format, ...) PRINTF_ATTRIBUTE (1, 2);
> +_internal_error (const char *format, ...) PRINTF_ATTRIBUTE (1, 2) __attribute__ ((noreturn));
>
> /* There's no point in continuing when we've detected that we've done
> * something wrong internally (as opposed to the user passing in a
next prev parent reply other threads:[~2012-09-22 16:13 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-21 12:50 [PATCH 1/2] Annotate internal_error with the attribute noreturn Justus Winter
2012-09-21 12:50 ` [PATCH 2/2] Avoid potentially dereferencing a NULL pointer Justus Winter
2012-09-22 16:19 ` Austin Clements
2012-09-24 12:55 ` Justus Winter
2012-09-21 20:31 ` [PATCH 1/2] Annotate internal_error with the attribute noreturn David Bremner
2012-09-22 16:12 ` Austin Clements [this message]
2012-09-22 20:03 ` Tomi Ollila
2012-09-24 10:31 ` RFC: Annotate internal_error with the attribute noreturn 2nd patchset Justus Winter
2012-09-24 10:31 ` [PATCH 1/5] RFC: Provide a __has_attribute compatibility macro Justus Winter
2012-09-24 10:31 ` [PATCH 2/5] RFC: Provide a NORETURN_ATTRIBUTE macro similar to PRINTF_ATTRIBUTE Justus Winter
2012-09-24 10:31 ` [PATCH 3/5] Fix the COERCE_STATUS macro Justus Winter
2012-09-24 10:31 ` [PATCH 4/5] Annotate internal_error with the attribute noreturn Justus Winter
2012-09-24 10:31 ` [PATCH 5/5] Avoid potentially dereferencing a NULL pointer Justus Winter
2012-09-24 10:44 ` RFC: Annotate internal_error with the attribute noreturn 2nd patchset David Bremner
2012-09-24 12:50 ` Justus Winter
2012-09-24 14:41 ` David Bremner
2012-09-24 15:21 ` [PATCH 1/6] Provide a __has_attribute compatibility macro Justus Winter
2012-09-24 15:21 ` [PATCH 2/6] Provide a NORETURN_ATTRIBUTE macro similar to PRINTF_ATTRIBUTE Justus Winter
2012-09-24 15:21 ` [PATCH 3/6] Extend compat/README Justus Winter
2012-09-24 15:21 ` [PATCH 4/6] Fix the COERCE_STATUS macro Justus Winter
2012-09-24 17:44 ` Austin Clements
2012-09-25 8:55 ` Tomi Ollila
2012-09-24 15:21 ` [PATCH 5/6] Annotate internal_error with the attribute noreturn Justus Winter
2012-09-24 15:21 ` [PATCH 6/6] Avoid potentially dereferencing a NULL pointer Justus Winter
2012-09-27 15:57 ` [PATCH 1/6] Provide a __has_attribute compatibility macro David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120922161256.GE26662@mit.edu \
--to=amdragon@mit.edu \
--cc=4winter@informatik.uni-hamburg.de \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).