* [PATCH] tag: remove unused attribute from notmuch_tag_command() arguments
@ 2012-01-28 8:02 Dmitry Kurochkin
2012-02-04 12:37 ` David Bremner
0 siblings, 1 reply; 4+ messages in thread
From: Dmitry Kurochkin @ 2012-01-28 8:02 UTC (permalink / raw)
To: notmuch
Argc and argv arguments are used in notmuch_tag_command() function.
So unused attribute is not appropriate for them.
---
notmuch-tag.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/notmuch-tag.c b/notmuch-tag.c
index 44fd61f..36b9b09 100644
--- a/notmuch-tag.c
+++ b/notmuch-tag.c
@@ -111,7 +111,7 @@ _optimize_tag_query (void *ctx, const char *orig_query_string, char *argv[],
}
int
-notmuch_tag_command (void *ctx, unused (int argc), unused (char *argv[]))
+notmuch_tag_command (void *ctx, int argc, char *argv[])
{
int *add_tags, *remove_tags;
int add_tags_count = 0;
--
1.7.8.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] tag: remove unused attribute from notmuch_tag_command() arguments
2012-01-28 8:02 [PATCH] tag: remove unused attribute from notmuch_tag_command() arguments Dmitry Kurochkin
@ 2012-02-04 12:37 ` David Bremner
2012-02-05 19:34 ` Dmitry Kurochkin
0 siblings, 1 reply; 4+ messages in thread
From: David Bremner @ 2012-02-04 12:37 UTC (permalink / raw)
To: Dmitry Kurochkin, notmuch
On Sat, 28 Jan 2012 12:02:33 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> Argc and argv arguments are used in notmuch_tag_command() function.
> So unused attribute is not appropriate for them.
pushed,
d
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tag: remove unused attribute from notmuch_tag_command() arguments
2012-02-04 12:37 ` David Bremner
@ 2012-02-05 19:34 ` Dmitry Kurochkin
2012-02-08 13:22 ` David Bremner
0 siblings, 1 reply; 4+ messages in thread
From: Dmitry Kurochkin @ 2012-02-05 19:34 UTC (permalink / raw)
To: David Bremner, notmuch
On Sat, 04 Feb 2012 07:37:45 -0500, David Bremner <david@tethera.net> wrote:
> On Sat, 28 Jan 2012 12:02:33 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> > Argc and argv arguments are used in notmuch_tag_command() function.
> > So unused attribute is not appropriate for them.
>
> pushed,
>
Are you sure? I do not see it in master.
Regards,
Dmitry
> d
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tag: remove unused attribute from notmuch_tag_command() arguments
2012-02-05 19:34 ` Dmitry Kurochkin
@ 2012-02-08 13:22 ` David Bremner
0 siblings, 0 replies; 4+ messages in thread
From: David Bremner @ 2012-02-08 13:22 UTC (permalink / raw)
To: Dmitry Kurochkin, notmuch
On Sun, 05 Feb 2012 23:34:44 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
>
> Are you sure? I do not see it in master.
>
Oops. Should be there now.
d
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-02-08 13:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-28 8:02 [PATCH] tag: remove unused attribute from notmuch_tag_command() arguments Dmitry Kurochkin
2012-02-04 12:37 ` David Bremner
2012-02-05 19:34 ` Dmitry Kurochkin
2012-02-08 13:22 ` David Bremner
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).