From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 66A09431FAF for ; Sat, 4 Feb 2012 04:37:48 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.3 X-Spam-Level: X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id osHHg3MNzaVu for ; Sat, 4 Feb 2012 04:37:48 -0800 (PST) Received: from tempo.its.unb.ca (tempo.its.unb.ca [131.202.1.21]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 00E56431FAE for ; Sat, 4 Feb 2012 04:37:47 -0800 (PST) Received: from rocinante.cs.unb.ca ([209.226.201.250]) (authenticated bits=0) by tempo.its.unb.ca (8.13.8/8.13.8) with ESMTP id q14CbkGX015272 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO); Sat, 4 Feb 2012 08:37:46 -0400 Received: from bremner by rocinante.cs.unb.ca with local (Exim 4.77) (envelope-from ) id 1RtesD-0000In-TU; Sat, 04 Feb 2012 07:37:45 -0500 From: David Bremner To: Dmitry Kurochkin , notmuch@notmuchmail.org Subject: Re: [PATCH] tag: remove unused attribute from notmuch_tag_command() arguments In-Reply-To: <1327737753-18068-1-git-send-email-dmitry.kurochkin@gmail.com> References: <1327737753-18068-1-git-send-email-dmitry.kurochkin@gmail.com> User-Agent: Notmuch/0.11.1 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Sat, 04 Feb 2012 07:37:45 -0500 Message-ID: <87y5sisrja.fsf@rocinante.cs.unb.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Feb 2012 12:37:48 -0000 On Sat, 28 Jan 2012 12:02:33 +0400, Dmitry Kurochkin wrote: > Argc and argv arguments are used in notmuch_tag_command() function. > So unused attribute is not appropriate for them. pushed, d