unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
* [PATCH] t/lei-mirror: do not bail out on `make help' failure
@ 2023-09-14 12:12 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2023-09-14 12:12 UTC (permalink / raw)
  To: meta

I'm not sure why, but this test occasionally fails on OpenBSD
and I can't reproduce it on a repeatable basis.  In any case,
there's no reason we can't continue the rest of the test if
`make help' fails.
---
 t/lei-mirror.t | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/t/lei-mirror.t b/t/lei-mirror.t
index 2400578a..9b5d73ec 100644
--- a/t/lei-mirror.t
+++ b/t/lei-mirror.t
@@ -27,7 +27,8 @@ test_lei({ tmpdir => $tmpdir }, sub {
 		"mirror of $http/t1/\n", 'description set');
 	ok(-f "$t1/Makefile", 'convenience Makefile added (v1)');
 	my $make = which('make');
-	xsys_e([$make, 'help'], undef, { -C => $t1, 1 => \(my $help) });
+	is(xsys([$make, 'help'], undef, { -C => $t1, 1 => \(my $help) }), 0,
+		'make help');
 	ok(-f "$t1/inbox.config.example", 'inbox.config.example downloaded');
 	isnt($help, '', 'make help worked');
 	is((stat(_))[9], $created{v1},

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2023-09-14 12:12 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-14 12:12 [PATCH] t/lei-mirror: do not bail out on `make help' failure Eric Wong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).