From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] t/lei-mirror: do not bail out on `make help' failure
Date: Thu, 14 Sep 2023 12:12:55 +0000 [thread overview]
Message-ID: <20230914121256.1897288-1-e@80x24.org> (raw)
I'm not sure why, but this test occasionally fails on OpenBSD
and I can't reproduce it on a repeatable basis. In any case,
there's no reason we can't continue the rest of the test if
`make help' fails.
---
t/lei-mirror.t | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/t/lei-mirror.t b/t/lei-mirror.t
index 2400578a..9b5d73ec 100644
--- a/t/lei-mirror.t
+++ b/t/lei-mirror.t
@@ -27,7 +27,8 @@ test_lei({ tmpdir => $tmpdir }, sub {
"mirror of $http/t1/\n", 'description set');
ok(-f "$t1/Makefile", 'convenience Makefile added (v1)');
my $make = which('make');
- xsys_e([$make, 'help'], undef, { -C => $t1, 1 => \(my $help) });
+ is(xsys([$make, 'help'], undef, { -C => $t1, 1 => \(my $help) }), 0,
+ 'make help');
ok(-f "$t1/inbox.config.example", 'inbox.config.example downloaded');
isnt($help, '', 'make help worked');
is((stat(_))[9], $created{v1},
reply other threads:[~2023-09-14 12:12 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230914121256.1897288-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).