* [PATCH] sha: fix compatibility with old OpenSSL + Net::SSLeay
@ 2023-03-07 8:47 Eric Wong
0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2023-03-07 8:47 UTC (permalink / raw)
To: meta
In older OpenSSL, EVP_get_digestbyname() didn't work properly
without calling OpenSSL_add_all_digests(), first. However,
OpenSSL_add_all_digests() is deprecated by OpenSSL 1.1.0 in
favor of OPENSSL_init_crypto(). Of course, OpenSSL_init_crypto()
isn't available in OpenSSL 1.0.1k nor Net::SSLeay as of 1.93_02
(2023-02-22).
Thus, instead of relying on string lookups and conditional
subroutine calls, just call EVP_sha1() and EVP_sha256() which
work on both old and new systems.
Tested with Net::SSLeay 1.55 and OpenSSL 1.0.1k on on CentOS 7.x
---
lib/PublicInbox/SHA.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/SHA.pm b/lib/PublicInbox/SHA.pm
index da70beef..81f62618 100644
--- a/lib/PublicInbox/SHA.pm
+++ b/lib/PublicInbox/SHA.pm
@@ -20,8 +20,8 @@ BEGIN {
unless (eval(<<'EOM')) {
use Net::SSLeay 1.43;
my %SHA = (
- 1 => Net::SSLeay::EVP_get_digestbyname('sha1'),
- 256 => Net::SSLeay::EVP_get_digestbyname('sha256'),
+ 1 => Net::SSLeay::EVP_sha1(),
+ 256 => Net::SSLeay::EVP_sha256(),
);
sub new {
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2023-03-07 8:47 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-07 8:47 [PATCH] sha: fix compatibility with old OpenSSL + Net::SSLeay Eric Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).