From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] sha: fix compatibility with old OpenSSL + Net::SSLeay
Date: Tue, 7 Mar 2023 08:47:15 +0000 [thread overview]
Message-ID: <20230307084715.398251-1-e@80x24.org> (raw)
In older OpenSSL, EVP_get_digestbyname() didn't work properly
without calling OpenSSL_add_all_digests(), first. However,
OpenSSL_add_all_digests() is deprecated by OpenSSL 1.1.0 in
favor of OPENSSL_init_crypto(). Of course, OpenSSL_init_crypto()
isn't available in OpenSSL 1.0.1k nor Net::SSLeay as of 1.93_02
(2023-02-22).
Thus, instead of relying on string lookups and conditional
subroutine calls, just call EVP_sha1() and EVP_sha256() which
work on both old and new systems.
Tested with Net::SSLeay 1.55 and OpenSSL 1.0.1k on on CentOS 7.x
---
lib/PublicInbox/SHA.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/SHA.pm b/lib/PublicInbox/SHA.pm
index da70beef..81f62618 100644
--- a/lib/PublicInbox/SHA.pm
+++ b/lib/PublicInbox/SHA.pm
@@ -20,8 +20,8 @@ BEGIN {
unless (eval(<<'EOM')) {
use Net::SSLeay 1.43;
my %SHA = (
- 1 => Net::SSLeay::EVP_get_digestbyname('sha1'),
- 256 => Net::SSLeay::EVP_get_digestbyname('sha256'),
+ 1 => Net::SSLeay::EVP_sha1(),
+ 256 => Net::SSLeay::EVP_sha256(),
);
sub new {
reply other threads:[~2023-03-07 8:47 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230307084715.398251-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).