unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
* [PATCH] test_common: avoid uninitialized warning on readlink
@ 2022-07-09  8:08 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2022-07-09  8:08 UTC (permalink / raw)
  To: meta

Of course, waiting for inotify to become active can't rely on
inotify, so we need to do a busy loop here, instead...
---
 lib/PublicInbox/TestCommon.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/PublicInbox/TestCommon.pm b/lib/PublicInbox/TestCommon.pm
index 943dd2fa..ecf7a261 100644
--- a/lib/PublicInbox/TestCommon.pm
+++ b/lib/PublicInbox/TestCommon.pm
@@ -378,7 +378,7 @@ sub wait_for_tail {
 		my @ino;
 		do {
 			@ino = grep {
-				readlink($_) =~ /\binotify\b/
+				(readlink($_) // '') =~ /\binotify\b/
 			} glob("/proc/$tail_pid/fd/*");
 		} while (!@ino && time <= $end and tick);
 		return if !@ino;

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-07-09  8:08 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-09  8:08 [PATCH] test_common: avoid uninitialized warning on readlink Eric Wong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).