unofficial mirror of
 help / color / mirror / Atom feed
From: Eric Wong <>
Subject: [PATCH] test_common: avoid uninitialized warning on readlink
Date: Sat,  9 Jul 2022 08:08:57 +0000	[thread overview]
Message-ID: <> (raw)

Of course, waiting for inotify to become active can't rely on
inotify, so we need to do a busy loop here, instead...
 lib/PublicInbox/ | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/PublicInbox/ b/lib/PublicInbox/
index 943dd2fa..ecf7a261 100644
--- a/lib/PublicInbox/
+++ b/lib/PublicInbox/
@@ -378,7 +378,7 @@ sub wait_for_tail {
 		my @ino;
 		do {
 			@ino = grep {
-				readlink($_) =~ /\binotify\b/
+				(readlink($_) // '') =~ /\binotify\b/
 			} glob("/proc/$tail_pid/fd/*");
 		} while (!@ino && time <= $end and tick);
 		return if !@ino;

                 reply	other threads:[~2022-07-09  8:08 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).