unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 2/3] extindex: improve comment around git->async_wait_all
Date: Sun, 25 Jul 2021 00:11:02 +0000	[thread overview]
Message-ID: <20210725001103.11638-3-e@80x24.org> (raw)
In-Reply-To: <20210725001103.11638-1-e@80x24.org>

I found myself tempted to remove this, but it appears impossible
due to odd messages which have multiple Message-IDs.
---
 lib/PublicInbox/ExtSearchIdx.pm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lib/PublicInbox/ExtSearchIdx.pm b/lib/PublicInbox/ExtSearchIdx.pm
index 2311161e..1c2a9758 100644
--- a/lib/PublicInbox/ExtSearchIdx.pm
+++ b/lib/PublicInbox/ExtSearchIdx.pm
@@ -937,7 +937,9 @@ EOS
 			};
 			$self->git->cat_async($smsg->{blob}, \&dd_smsg, $dd);
 		}
-		# need to wait on every single one
+		# need to wait on every single one @smsg contents can get
+		# invalidated inside dd_smsg for messages with multiple
+		# Message-IDs.
 		$self->git->async_wait_all;
 
 		if (checkpoint_due($sync)) {

  parent reply	other threads:[~2021-07-25  0:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-22  8:50 [WIP] extindex: support --dedupe[=MSGID] Eric Wong
2021-07-24  6:34 ` Eric Wong
2021-07-25  0:11   ` [PATCH 0/3] extindex dedupe improvements Eric Wong
2021-07-25  0:11     ` [PATCH 1/3] extindex: support --dedupe[=MSGID] Eric Wong
2021-07-25  0:11     ` Eric Wong [this message]
2021-07-25  0:11     ` [PATCH 3/3] extsearchidx: use more appropriate max for dedupe Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210725001103.11638-3-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).