From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 3/3] extsearchidx: use more appropriate max for dedupe
Date: Sun, 25 Jul 2021 00:11:03 +0000 [thread overview]
Message-ID: <20210725001103.11638-4-e@80x24.org> (raw)
In-Reply-To: <20210725001103.11638-1-e@80x24.org>
The over.msgid table may contain ghost Message-IDs and also
Message-IDs of deleted spam messages, so over->max isn't a
good aproproximation of dedupe progress.
---
lib/PublicInbox/ExtSearchIdx.pm | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/lib/PublicInbox/ExtSearchIdx.pm b/lib/PublicInbox/ExtSearchIdx.pm
index 1c2a9758..51dbf54f 100644
--- a/lib/PublicInbox/ExtSearchIdx.pm
+++ b/lib/PublicInbox/ExtSearchIdx.pm
@@ -896,7 +896,10 @@ sub eidx_dedupe ($$$) {
my ($iter, $cur_mid);
my $min_id = 0;
my $idx = 0;
- local $sync->{-regen_fmt} = "dedupe %u/".$self->{oidx}->max."\n";
+ my ($max_id) = $self->{oidx}->dbh->selectrow_array(<<EOS);
+SELECT MAX(id) FROM msgid
+EOS
+ local $sync->{-regen_fmt} = "dedupe %u/$max_id\n";
# note: we could write this query more intelligently,
# but that causes lock contention with read-only processes
prev parent reply other threads:[~2021-07-25 0:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 8:50 [WIP] extindex: support --dedupe[=MSGID] Eric Wong
2021-07-24 6:34 ` Eric Wong
2021-07-25 0:11 ` [PATCH 0/3] extindex dedupe improvements Eric Wong
2021-07-25 0:11 ` [PATCH 1/3] extindex: support --dedupe[=MSGID] Eric Wong
2021-07-25 0:11 ` [PATCH 2/3] extindex: improve comment around git->async_wait_all Eric Wong
2021-07-25 0:11 ` Eric Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210725001103.11638-4-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).